yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-03 17:59:46 +02:00
Code Issues Releases Wiki Activity

GP-1 Disable replace action for BadDataType

Browse source
This commit is contained in:
ghidra1 2025-07-09 19:10:22 -04:00
parent f250cfeac4
commit 3f638e22b4
1 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/datamgr/actions/ReplaceDataTypeAction.java
View file

@ -67,10 +67,18 @@ public class ReplaceDataTypeAction extends DockingAction {
return false; return false;
} }
if (!(node instanceof DataTypeNode)) { if (!(node instanceof DataTypeNode dtNode)) {
return false; return false;
} }
return node.isModifiable(); if (!dtNode.isModifiable()) {
return false;
}
if (dtNode.getDataType() instanceof BadDataType) {
// Although BAD datatype should not appear in tree, if it does replace is
// not supported. Delete should be used instead.
return false;
}
return true;
} }
private DataTypeTreeNode getSelectedDataTypeTreeNode(ActionContext context) { private DataTypeTreeNode getSelectedDataTypeTreeNode(ActionContext context) {