diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/importer/LibrarySearchPathManager.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/importer/LibrarySearchPathManager.java index df683f02b7..7c47f4d065 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/importer/LibrarySearchPathManager.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/importer/LibrarySearchPathManager.java @@ -20,7 +20,6 @@ import java.io.IOException; import java.net.MalformedURLException; import java.util.*; -import ghidra.app.util.bin.ByteProvider; import ghidra.app.util.opinion.Loader; import ghidra.formats.gfilesystem.*; import ghidra.framework.Platform; @@ -53,15 +52,14 @@ public class LibrarySearchPathManager { /** * Returns a {@link List} of {@link FSRL}s to search for libraries * - * @param provider The {@link ByteProvider} of the program being loaded * @param program The {@link Program} being loaded * @param log The log * @param monitor A cancellable monitor * @return a {@link List} of {@link FSRL}s to search for libraries * @throws CancelledException if the user cancelled the operation */ - public static synchronized List getLibraryFsrlList(ByteProvider provider, Program program, - MessageLog log, TaskMonitor monitor) throws CancelledException { + public static synchronized List getLibraryFsrlList(Program program, MessageLog log, + TaskMonitor monitor) throws CancelledException { FileSystemService fsService = FileSystemService.getInstance(); List fsrlList = new ArrayList<>(); for (String path : pathSet) { @@ -70,10 +68,7 @@ public class LibrarySearchPathManager { FSRL fsrl = null; try { if (path.equals(".")) { - FSRL providerFsrl = provider.getFSRL(); - if (providerFsrl == null) { - providerFsrl = FSRL.fromProgram(program); - } + FSRL providerFsrl = FSRL.fromProgram(program); if (providerFsrl != null) { try (RefdFile fileRef = fsService.getRefdFile(providerFsrl, monitor)) { GFile parentFile = fileRef.file.getParentFile(); diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/AbstractLibrarySupportLoader.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/AbstractLibrarySupportLoader.java index 9a02a1512f..8fd083c233 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/AbstractLibrarySupportLoader.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/opinion/AbstractLibrarySupportLoader.java @@ -17,7 +17,6 @@ package ghidra.app.util.opinion; import java.io.File; import java.io.IOException; -import java.nio.file.InvalidPathException; import java.nio.file.Path; import java.util.*; import java.util.function.Predicate; @@ -25,7 +24,6 @@ import java.util.stream.Collectors; import java.util.stream.Stream; import org.apache.commons.io.FilenameUtils; -import org.apache.commons.lang3.ObjectUtils; import ghidra.app.util.Option; import ghidra.app.util.OptionUtils; @@ -122,9 +120,8 @@ public abstract class AbstractLibrarySupportLoader extends AbstractProgramLoader } // Load the libraries - List> libraries = loadLibraries(provider, program, project, - projectFolderPath, loadSpec, options, log, consumer, libraryNameList, monitor); - loadedProgramList.addAll(libraries); + loadedProgramList.addAll(loadLibraries(provider, program, project, projectFolderPath, + loadSpec, options, log, consumer, libraryNameList, monitor)); success = true; return loadedProgramList; @@ -162,7 +159,7 @@ public abstract class AbstractLibrarySupportLoader extends AbstractProgramLoader */ @Override protected void postLoadProgramFixups(List> loadedPrograms, Project project, - List