yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-04 18:29:37 +02:00
Code Issues Releases Wiki Activity

GP-3127 - PDB - Override overzealous thunk detection

Browse source
This commit is contained in:
ghizard 2023-02-22 15:10:38 -05:00
parent bdc6f56c40
commit 407fe706d8
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Ghidra/Features/PDB/src/main/java/ghidra/app/util/pdb/pdbapplicator/FunctionSymbolApplier.java
View file

@ -258,10 +258,12 @@ public class FunctionSymbolApplier extends MsSymbolApplier {
}
boolean succeededSetFunctionSignature = false;
if (!function.isThunk() &&
function.getSignatureSource().isLowerPriorityThan(SourceType.IMPORTED)) {
succeededSetFunctionSignature = setFunctionDefinition(monitor);
function.setNoReturn(isNonReturning);
if (thunkSymbol == null) {
function.setThunkedFunction(null);
if (function.getSignatureSource().isLowerPriorityThan(SourceType.IMPORTED)) {
succeededSetFunctionSignature = setFunctionDefinition(monitor);
function.setNoReturn(isNonReturning);
}
}
// If signature was set, then override existing primary mangled symbol with
// the global symbol that provided this signature so that Demangler does not overwrite