yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-05 10:49:34 +02:00
Code Issues Releases Wiki Activity

consistent naming of parameters between Ghidra and decompiler

Browse source
This commit is contained in:
caheckman 2019-09-18 15:47:23 -04:00
parent 23cb2634ab
commit 4ed9f2f0ee
2 changed files with 8 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Ghidra/Features/Decompiler/src/decompile/cpp/database.cc
View file

@ -2056,9 +2056,7 @@ string ScopeInternal::buildVariableName(const Address &addr,
s << "in_" << regname; s << "in_" << regname;
} }
else if ((flags & Varnode::input)!=0) { // Regular parameter else if ((flags & Varnode::input)!=0) { // Regular parameter
if (ct != (Datatype *)0) s << "param_" << dec << index;
ct->printNameBase(s);
s << "Parm" << dec << index;
} }
else if ((flags & Varnode::addrtied)!=0) { else if ((flags & Varnode::addrtied)!=0) {
if (ct != (Datatype *)0) if (ct != (Datatype *)0)

14
Ghidra/Features/Decompiler/src/main/java/ghidra/app/plugin/core/decompile/actions/RetypeVariableAction.java
View file

@ -129,13 +129,13 @@ public class RetypeVariableAction extends AbstractDecompilerAction {
boolean commitRequired = checkFullCommit(var, hfunction); boolean commitRequired = checkFullCommit(var, hfunction);
if (commitRequired) { if (commitRequired) {
int resp = OptionDialog.showOptionDialog(tool.getToolFrame(), // int resp = OptionDialog.showOptionDialog(tool.getToolFrame(),
"Parameter Commit Required", // "Parameter Commit Required",
"Retyping a parameter requires all other parameters to be committed!\nContinue with retype?", // "Retyping a parameter requires all other parameters to be committed!\nContinue with retype?",
"Continue"); // "Continue");
if (resp != OptionDialog.OPTION_ONE) { // if (resp != OptionDialog.OPTION_ONE) {
return; // return;
} // }
exactSpot = null; // Don't try to split out if commit is required exactSpot = null; // Don't try to split out if commit is required
} }