From c703e4541fe63b6f5117de851f1ddd7d45113e1d Mon Sep 17 00:00:00 2001 From: dev747368 <48332326+dev747368@users.noreply.github.com> Date: Mon, 8 Sep 2025 16:03:42 +0000 Subject: [PATCH] GP-0 fix golang javadoc errors --- .../app/util/bin/format/golang/rtti/GoTypeManager.java | 2 -- .../app/util/bin/format/golang/rtti/types/GoMapType.java | 5 +---- .../ghidra/app/util/bin/format/golang/rtti/types/GoType.java | 1 - .../app/util/bin/format/golang/rtti/types/GoTypeBridge.java | 2 +- 4 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/GoTypeManager.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/GoTypeManager.java index e922a8b5c1..21345321f7 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/GoTypeManager.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/GoTypeManager.java @@ -320,9 +320,7 @@ public class GoTypeManager { /** * Finds a Ghidra data type by its go-type name. * - * @param Ghidra DataType generic type specifier * @param typeName go type name - * @param clazz {@link DataType} class reference * @return Ghidra {@link DataType} corresponding to the requested name, coerced into a * specific {@link DataType} subclass, or {@code NULL} if not found * @throws IOException if error diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoMapType.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoMapType.java index 9e06e898d0..0d926d13c4 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoMapType.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoMapType.java @@ -27,10 +27,7 @@ import ghidra.util.Msg; /** * Go type info about a specific map type. *

- * See {@link GoTypeManager#getMapGoType()} or the "runtime.hmap" type for the definition of - * a instance of a map variable in memory. - *

- * Maps are passed by address, and sizeof(mapvar) will always be ptrSize + * Maps are passed by address, and in Go sizeof(mapvar) will always be ptrSize */ @StructureMapping( structureName = { "runtime.maptype", "internal/abi.MapType", "internal/abi.OldMapType" } diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoType.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoType.java index 24370dec3e..9b9dafa46c 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoType.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoType.java @@ -303,7 +303,6 @@ public abstract class GoType implements StructureMarkup, StructureVerifi *

* This default implementation just creates an opaque blob of the appropriate size * - * @param goTypes {@link GoTypeManager} * @return {@link DataType} that represents the Go type * @throws IOException if error getting name of the type */ diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoTypeBridge.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoTypeBridge.java index 623f12dabb..f59025dcfc 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoTypeBridge.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/golang/rtti/types/GoTypeBridge.java @@ -23,7 +23,7 @@ import ghidra.program.model.data.DataType; /** * A limited use wrapper/bridge between a GoType and a Ghidra DataType, this - * wrapper only supports the {@link #recoverDataType(GoTypeManager)} call. + * wrapper only supports the {@link #recoverDataType()} call. */ public class GoTypeBridge extends GoType {