Corrected ARM/Thumb adcs/sbcs flag update macros.

This commit is contained in:
ghidorahrex 2021-08-17 10:47:43 -04:00
parent 0956746cf7
commit 7130901ed5
9 changed files with 226 additions and 21 deletions

View file

@ -0,0 +1,43 @@
#include "pcode_test.h"
/* This test checks the correct carry flag handling for adc instructions */
TEST arm_adc_Main()
{
extern u4 u4_adc_carry(u4 a, u4 b, u1 carry);
extern u4 u4_adc_overflow(u4 a, u4 b, u1 carry);
ASSERTU1(u4_adc_carry(0xffffffff, 0, 1), 1);
ASSERTU1(u4_adc_carry(0, 0xffffffff, 1), 1);
ASSERTU1(u4_adc_carry(1, 0xffffffff, 1), 1);
ASSERTU1(u4_adc_carry(0xffffffff, 1, 1), 1);
ASSERTU1(u4_adc_carry(1, 0xfffffffe, 1), 1);
ASSERTU1(u4_adc_carry(0xfffffffe, 1, 1), 1);
ASSERTU1(u4_adc_carry(0xffffffff, 0, 0), 0);
ASSERTU1(u4_adc_carry(0, 0xffffffff, 0), 0);
ASSERTU1(u4_adc_carry(1, 0xffffffff, 0), 1);
ASSERTU1(u4_adc_carry(0xffffffff, 1, 0), 1);
ASSERTU1(u4_adc_carry(1, 0xfffffffe, 0), 0);
ASSERTU1(u4_adc_carry(0xfffffffe, 1, 0), 0);
ASSERTU1(u4_adc_overflow(0x80000000, 0xffffffff, 1), 0);
}
/* This test checks the correct carry flag handling for sbc instructions */
TEST arm_sbc_Main()
{
extern u4 u4_sbc_carry(i4 a, i4 b, u1 carry);
ASSERTU1(u4_sbc_carry(-1, 0, 0), 1);
ASSERTU1(u4_sbc_carry(0, 0x7fffffff, 0), 0);
ASSERTU1(u4_sbc_carry(-1, 0x7fffffff, 0), 1);
ASSERTU1(u4_sbc_carry(-1, 1, 1), 1);
ASSERTU1(u4_sbc_carry(1, 1, 1), 1);
ASSERTU1(u4_sbc_carry(-1, 1, 1), 1);
extern i4 i4_sbc(i4 a, i4 b, u1 carry);
ASSERTU1(i4_sbc(0, 0, 0), -1);
ASSERTU1(i4_sbc(-1, 0, 0), -2);
ASSERTU1(i4_sbc(0, 0, 1), 0);
ASSERTU1(i4_sbc(0, 1, 1), -1);
ASSERTU1(i4_sbc(2, 1, 0), 0);
}
MAIN asm_main() { }

View file

@ -0,0 +1,149 @@
/* ###
* IP: GHIDRA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include "pcode_test.h"
u4 u4_adc_carry(u4 a, u4 b, u1 carry)
{
u4 res = 0;
u4 x = 0xffffffff;
u4 y = 1;
if (carry == 1) {
__asm__(
".syntax unified\n"
"adds %[x_res],%[x],%[y]\n" /* set the carry flag */
: [x_res] "=r" (x)
: [x] "r" (x), [y] "r" (y)
);
} else {
__asm__(
".syntax unified\n"
"adds %[x_res],%[y],%[y]\n" /* clear the carry flag */
: [x_res] "=r" (x)
: [y] "r" (y)
);
}
__asm__(
".syntax unified\n"
"adcs %[input_a],%[input_a],%[input_b]\n"
"bcc adc_nocarry\n"
"ldr %[result], =0x1\n"
"b adc_end\n"
"adc_nocarry:\n"
"ldr %[result], =0x0\n"
"adc_end:\n"
: [result] "=r" (res)
: [input_a] "r" (a), [input_b] "r" (b)
);
return res;
}
u4 u4_adc_overflow(u4 a, u4 b, u1 carry)
{
u4 res = 0;
u4 x = 0xffffffff;
u4 y = 1;
if (carry == 1) {
__asm__(
".syntax unified\n"
"adds %[x_res],%[x],%[y]\n" /* set the carry flag */
: [x_res] "=r" (x)
: [x] "r" (x), [y] "r" (y)
);
} else {
__asm__(
".syntax unified\n"
"adds %[x_res],%[y],%[y]\n" /* clear the carry flag */
: [x_res] "=r" (x)
: [y] "r" (y)
);
}
__asm__(
".syntax unified\n"
"adcs %[input_a],%[input_a],%[input_b], lsr #1\n"
"bvc adc_noover\n"
"ldr %[result], =0x1\n"
"b adc_o_end\n"
"adc_noover:\n"
"ldr %[result], =0x0\n"
"adc_o_end:\n"
: [result] "=r" (res)
: [input_a] "r" (a), [input_b] "r" (b)
);
return res;
}
u4 u4_sbc_carry(i4 a, i4 b, u1 carry)
{
u4 res = 0;
u4 x = 0xffffffff;
u4 y = 1;
if (carry == 1) {
__asm__(
".syntax unified\n"
"adds %[x_res],%[x],%[y]\n" /* set the carry flag */
: [x_res] "=r" (x)
: [x] "r" (x), [y] "r" (y)
);
} else {
__asm__(
".syntax unified\n"
"adds %[x_res],%[y],%[y]\n" /* clear the carry flag */
: [x_res] "=r" (x)
: [y] "r" (y)
);
}
__asm__(
".syntax unified\n"
"sbcs %[input_a],%[input_a],%[input_b]\n"
"bcc sbc_nocarry\n"
"ldr %[result], =0x1\n"
"b sbc_end\n"
"sbc_nocarry:\n"
"ldr %[result], =0x0\n"
"sbc_end:\n"
: [result] "=r" (res)
: [input_a] "r" (a), [input_b] "r" (b)
);
return res;
}
i4 i4_sbc(i4 a, i4 b, u1 carry)
{
u4 res = 0;
u4 x = 0xffffffff;
u4 y = 1;
if (carry == 1) {
__asm__(
".syntax unified\n"
"adds %[x_res],%[x],%[y]\n" /* set the carry flag */
: [x_res] "=r" (x)
: [x] "r" (x), [y] "r" (y)
);
} else {
__asm__(
".syntax unified\n"
"adds %[x_res],%[y],%[y]\n" /* clear the carry flag */
: [x_res] "=r" (x)
: [y] "r" (y)
);
}
__asm__(
"sbc %[result],%[input_a],%[input_b]\n"
: [result] "=r" (res)
: [input_a] "r" (a), [input_b] "r" (b)
);
return res;
}