yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-05 02:39:44 +02:00
Code Issues Releases Wiki Activity

hidden extensions with multiple descendants

Browse source
This commit is contained in:
caheckman 2019-05-10 09:56:09 -04:00
parent 8860979785
commit 7870b20f96
1 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Ghidra/Features/Decompiler/src/decompile/cpp/printc.cc
View file

@ -1289,14 +1289,15 @@ bool PrintC::isExtensionCastImplied(const PcodeOp *op) const
} }
else { else {
PcodeOp *expOp = outVn->loneDescend();
if (expOp != (PcodeOp *)0) {
type_metatype metatype = outVn->getHigh()->getType()->getMetatype(); type_metatype metatype = outVn->getHigh()->getType()->getMetatype();
list<PcodeOp *>::const_iterator iter;
for(iter=outVn->beginDescend();iter!=outVn->endDescend();++iter) {
PcodeOp *expOp = *iter;
Varnode *otherVn; Varnode *otherVn;
int4 slot; int4 slot;
switch(expOp->code()) { switch(expOp->code()) {
case CPUI_PTRADD: case CPUI_PTRADD:
return true; break;
case CPUI_INT_ADD: case CPUI_INT_ADD:
case CPUI_INT_SUB: case CPUI_INT_SUB:
case CPUI_INT_MULT: case CPUI_INT_MULT:
@ -1311,13 +1312,16 @@ bool PrintC::isExtensionCastImplied(const PcodeOp *op) const
slot = expOp->getSlot(outVn); slot = expOp->getSlot(outVn);
otherVn = expOp->getIn(1-slot); otherVn = expOp->getIn(1-slot);
// Check if the expression involves an explicit variable of the right integer type // Check if the expression involves an explicit variable of the right integer type
if (otherVn->isExplicit() && otherVn->getHigh()->getType()->getMetatype() == metatype) if (!otherVn->isExplicit())
return true; return false;
if (otherVn->getHigh()->getType()->getMetatype() != metatype)
return false;
break; break;
default: default:
break; return false;
} }
} }
return true; // Everything is integer promotion
} }
return false; return false;
} }