yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-05 10:49:34 +02:00
Code Issues Releases Wiki Activity

GP-0: Remove unnecessary 'synchronized' in DBTrace

Browse source
This commit is contained in:
Dan 2022-10-28 16:32:15 -04:00
parent 5a3209bca5
commit 7bc66c883e
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Ghidra/Debug/Framework-TraceModeling/src/main/java/ghidra/trace/database/DBTrace.java
View file

@ -580,8 +580,7 @@ public class DBTrace extends DBCachedDomainObjectAdapter implements Trace, Trace
} }
@Override @Override
// NOTE: addListener synchronizes on this and might generate callbacks immediately public DBTraceProgramView getFixedProgramView(long snap) {
public synchronized DBTraceProgramView getFixedProgramView(long snap) {
// NOTE: The new viewport will need to read from the time manager during init // NOTE: The new viewport will need to read from the time manager during init
DBTraceProgramView view; DBTraceProgramView view;
try (LockHold hold = lockRead()) { try (LockHold hold = lockRead()) {
@ -595,8 +594,7 @@ public class DBTrace extends DBCachedDomainObjectAdapter implements Trace, Trace
} }
@Override @Override
// NOTE: Ditto getFixedProgramView public DBTraceVariableSnapProgramView createProgramView(long snap) {
public synchronized DBTraceVariableSnapProgramView createProgramView(long snap) {
// NOTE: The new viewport will need to read from the time manager during init // NOTE: The new viewport will need to read from the time manager during init
DBTraceVariableSnapProgramView view; DBTraceVariableSnapProgramView view;
try (LockHold hold = lockRead()) { try (LockHold hold = lockRead()) {
@ -613,7 +611,7 @@ public class DBTrace extends DBCachedDomainObjectAdapter implements Trace, Trace
} }
@Override @Override
public synchronized DBTraceTimeViewport createTimeViewport() { public DBTraceTimeViewport createTimeViewport() {
try (LockHold hold = lockRead()) { try (LockHold hold = lockRead()) {
DBTraceTimeViewport view = new DBTraceTimeViewport(this); DBTraceTimeViewport view = new DBTraceTimeViewport(this);
viewports.add(view); viewports.add(view);