From 7c88892b184c49aea8b30aff545c2561c2a5fe17 Mon Sep 17 00:00:00 2001
From: James <49045138+ghidracadabra@users.noreply.github.com>
Date: Mon, 18 Dec 2023 22:00:40 +0000
Subject: [PATCH] GP-0 more bsim tutorial typos
---
GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.html | 2 +-
GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.md | 2 +-
.../GhidraClass/BSim/BSimTutorial_Evaluating_Matches.html | 4 ++--
.../GhidraClass/BSim/BSimTutorial_Evaluating_Matches.md | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.html b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.html
index 8a24ad16ec..331432a81c 100755
--- a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.html
+++ b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.html
@@ -135,7 +135,7 @@ We use these different versions to demonstrate some of the capabilities of BSim.
- The Listing View tab shows the disassembly.
- The Decompiler Diff View tab shows the decompiled code.
- - Differences in the code are automatically highlighted in blue.
+ - Differences in the code are automatically highlighted in cyan.
- Either view can be toggled between a horizontal split and a vertical split using the drop-down menu.
diff --git a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.md b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.md
index c56d29908a..4dacc24b6d 100644
--- a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.md
+++ b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Basic_Queries.md
@@ -111,7 +111,7 @@ We use these different versions to demonstrate some of the capabilities of BSim.
1. Right-click on the row of the match and perform the **Compare Functions** action to bring up the side-by-side comparison.
- The **Listing View** tab shows the disassembly.
- The **Decompiler Diff View** tab shows the decompiled code.
- - Differences in the code are automatically highlighted in blue.
+ - Differences in the code are automatically highlighted in cyan.
- Either view can be toggled between a horizontal split and a vertical split using the drop-down menu.
1. Examine the diff views to verify that the match is valid.
1. Using the **Apply Name** action in the BSim Search Results table, apply the name from the search result to the queried function.
diff --git a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.html b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.html
index f70196747b..be7a5a6f1c 100755
--- a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.html
+++ b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.html
@@ -26,7 +26,7 @@ While doing this, we’ll showcase some of the features available in the decompi
The corresponding function in postgres
should have a default name.
Examine this match in the side-by-side decompiler view.
Note that the matching function has better data type information due to the debug information.
- Q: Why does the placement of the double
argument between the functions?
+ Q: Why does the placement of the double
argument differ between the functions?
Answer
Floating point values and integer/pointer values are passed in separate sets of registers.
Neither ordering is wrong since both are consistent with the instructions of the function.
The debug info records a specific signature (and ordering) for the function, which Ghidra applies.
@@ -44,7 +44,7 @@ Some terminology: if you click on a token in a decompiler panel, that token beco
The colors:
- - Blue is used to highlight differences between the two functions.
+ - Cyan is used to highlight differences between the two functions.
- Pink is used to highlight the focused token and its match.
- Lavender is used to highlight the focused token when it does not have a match.
- Orange is used to highlight the focused token when it is ineligible for match.
diff --git a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.md b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.md
index b6e21c5e44..69fb3f8c7e 100644
--- a/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.md
+++ b/GhidraDocs/GhidraClass/BSim/BSimTutorial_Evaluating_Matches.md
@@ -22,7 +22,7 @@ Import and analyze the stripped `postgres` executable into the tutorial project,
The corresponding function in `postgres` should have a default name.
1. Examine this match in the side-by-side decompiler view.
Note that the matching function has better data type information due to the debug information.
-1. Q: Why does the placement of the `double` argument between the functions?
+1. Q: Why does the placement of the `double` argument differ between the functions?
Answer
Floating point values and integer/pointer values are passed in separate sets of registers.
Neither ordering is wrong since both are consistent with the instructions of the function.
The debug info records a specific signature (and ordering) for the function, which Ghidra applies.
@@ -37,7 +37,7 @@ Some terminology: if you click on a token in a decompiler panel, that token beco
The colors:
-- Blue is used to highlight differences between the two functions.
+- Cyan is used to highlight differences between the two functions.
- Pink is used to highlight the focused token and its match.
- Lavender is used to highlight the focused token when it does not have a match.
- Orange is used to highlight the focused token when it is ineligible for match.