yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-04 02:09:44 +02:00
Code Issues Releases Wiki Activity

GP-0: Fixing @Override warnings

Browse source
This commit is contained in:
Ryan Kurtz 2025-05-29 06:16:20 -04:00
parent d4120b4b4d
commit a6cd5b5dbc
449 changed files with 2348 additions and 1276 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/api/correlator/program/ImpliedMatchProgramCorrelator.java
View file

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -38,6 +38,7 @@ public class ImpliedMatchProgramCorrelator extends VTAbstractProgramCorrelator {
// Do Nothing
}
@Override
public String getName() {
return NAME;
}

5
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/api/correlator/program/ManualMatchProgramCorrelator.java
View file

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -38,6 +38,7 @@ public class ManualMatchProgramCorrelator extends VTAbstractProgramCorrelator {
// Do Nothing
}
@Override
public String getName() {
return NAME;
}

5
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/api/db/VTMatchTagDB.java
View file

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -83,6 +83,7 @@ public class VTMatchTagDB extends DatabaseObject implements VTMatchTag {
return record.getString(TAG_NAME_COL.column());
}
@Override
public int compareTo(VTMatchTag otherTag) {
return getName().compareTo(otherTag.getName());
}

6
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/api/impl/MarkupItemStorageImpl.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -90,6 +89,7 @@ public class MarkupItemStorageImpl implements MarkupItemStorage {
return statusDescription;
}
@Override
public Stringable getSourceValue() {
return sourceValue;
}

20
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/api/impl/VTRelatedMatchImpl.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -55,23 +54,28 @@ public class VTRelatedMatchImpl implements VTRelatedMatch {
this.sourceFunction = sourceFunction;
}
public VTRelatedMatchType getCorrelation() {
@Override
public VTRelatedMatchType getCorrelation() {
return correlation;
}
public Address getDestinationAddress() {
@Override
public Address getDestinationAddress() {
return destinationAddress;
}
public Function getDestinationFunction() {
@Override
public Function getDestinationFunction() {
return destinationFunction;
}
public Address getSourceAddress() {
@Override
public Address getSourceAddress() {
return sourceAddress;
}
public Function getSourceFunction() {
@Override
public Function getSourceFunction() {
return sourceFunction;
}
}

6
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/api/main/VTMatchTag.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -32,6 +31,7 @@ public interface VTMatchTag extends Comparable<VTMatchTag> {
return "<Not Tagged>";
}
@Override
public int compareTo(VTMatchTag o) {
return getName().compareTo(o.getName());
}

8
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/actions/ProviderToggleAction.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -46,7 +45,8 @@ public class ProviderToggleAction extends ToggleDockingAction {
JComponent component = provider.getComponent();
component.addHierarchyListener( new HierarchyListener() {
public void hierarchyChanged( HierarchyEvent e ) {
@Override
public void hierarchyChanged( HierarchyEvent e ) {
long changeFlags = e.getChangeFlags();
if ( HierarchyEvent.SHOWING_CHANGED ==
(changeFlags & HierarchyEvent.SHOWING_CHANGED) ) {

6
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/editors/DisplayableOffset.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -26,6 +25,7 @@ public interface DisplayableOffset extends DisplayStringProvider, Comparable<Dis
public static String NO_OFFSET = "No Offset";
@Override
public String getDisplayString();
public Address getAddress();

5
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/provider/impliedmatches/MatchStatusUpdaterAssociationHook.java
View file

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -54,6 +54,7 @@ public class MatchStatusUpdaterAssociationHook implements AssociationHook, VTCon
updateMarkupStatus(markupItem.getAssociation());
}
@Override
public void sessionChanged(VTSession newSession) {
setSession(newSession);
}

5
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/provider/markuptable/DisplayableListingAddress.java
View file

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -30,6 +30,7 @@ public class DisplayableListingAddress implements DisplayableAddress {
this.address = listingAddress;
}
@Override
public Program getProgram() {
return program;
}

8
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/provider/markuptable/DisplayableListingOffset.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -57,14 +56,17 @@ public class DisplayableListingOffset implements DisplayableOffset {
return address;
}
@Override
public long getOffset() {
return offset;
}
@Override
public BigInteger getOffsetAsBigInteger() {
return offsetAsBigInteger;
}
@Override
public String getDisplayString() {
if (address == null || address == Address.NO_ADDRESS) {
return NO_OFFSET;

8
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/provider/markuptable/DisplayableVariableOffset.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -42,14 +41,17 @@ public class DisplayableVariableOffset implements DisplayableOffset {
return parameterAddress;
}
@Override
public long getOffset() {
return offset;
}
@Override
public BigInteger getOffsetAsBigInteger() {
return offsetAsBigInteger;
}
@Override
public String getDisplayString() {
if (parameterAddress == null || parameterAddress == Address.NO_ADDRESS) {
return NO_OFFSET;

5
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/util/FilterIconFlashTimer.java
View file

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -47,6 +47,7 @@ public class FilterIconFlashTimer<T> extends Timer implements ActionListener {
addActionListener(this);
}
@Override
public void actionPerformed(ActionEvent event) {
if (!filterDialog.isFiltered()) {
stop();

6
Ghidra/Features/VersionTracking/src/main/java/ghidra/feature/vt/gui/validator/VTPreconditionValidator.java
View file

@ -1,13 +1,12 @@
/* ###
* IP: GHIDRA
* REVIEWED: YES
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -45,6 +44,7 @@ public abstract class VTPreconditionValidator implements ConditionTester, Extens
return getName();
}
@Override
public final ConditionResult run(TaskMonitor monitor) throws CancelledException {
// make sure the program isn't closed while we are working