yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-03 09:49:23 +02:00
Code Issues Releases Wiki Activity

Test fixes for missing options help

Browse source
This commit is contained in:
dragonmacher 2025-01-29 12:14:27 -05:00
parent 3c86a0f3aa
commit abca848c4a
3 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/sourcefilestable/SourceFilesTablePlugin.java
View file

@ -322,7 +322,6 @@ public class SourceFilesTablePlugin extends ProgramPlugin implements OptionsChan
} }
private void initOptions(ToolOptions options) { private void initOptions(ToolOptions options) {
options.registerOption(USE_EXISTING_AS_DEFAULT_OPTION_NAME, true, options.registerOption(USE_EXISTING_AS_DEFAULT_OPTION_NAME, true,
new HelpLocation(getName(), "Use_Existing_As_Default"), new HelpLocation(getName(), "Use_Existing_As_Default"),
@ -336,8 +335,8 @@ public class SourceFilesTablePlugin extends ProgramPlugin implements OptionsChan
() -> new StringWithChoicesEditor(VIEWERS)); () -> new StringWithChoicesEditor(VIEWERS));
selectedViewer = options.getString(SELECTED_VIEWER_OPTION_NAME, VS_CODE); selectedViewer = options.getString(SELECTED_VIEWER_OPTION_NAME, VS_CODE);
options.addOptionsChangeListener(this); options.addOptionsChangeListener(this);
options.setOptionsHelpLocation(
new HelpLocation(getName(), "Source_Files_Table_Plugin_Options"));
} }
} }

1
Ghidra/Features/Base/src/main/java/ghidra/app/util/viewer/field/SourceMapFieldFactory.java
View file

@ -243,6 +243,7 @@ public class SourceMapFieldFactory extends FieldFactory {
"Show source file identifier info"); "Show source file identifier info");
showIdentifier = fieldOptions.getBoolean(SHOW_IDENTIFIER_OPTION_NAME, false); showIdentifier = fieldOptions.getBoolean(SHOW_IDENTIFIER_OPTION_NAME, false);
fieldOptions.getOptions(GROUP_TITLE).setOptionsHelpLocation(helpLoc);
} }
private List<SourceMapEntry> getSourceMapEntries(CodeUnit cu) { private List<SourceMapEntry> getSourceMapEntries(CodeUnit cu) {

6
Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/codebrowser/CodeBrowserOptionsTest.java
View file

@ -1007,13 +1007,15 @@ public class CodeBrowserOptionsTest extends AbstractGhidraHeadedIntegrationTest
List<HelpLocation> nestedHelp = getParentHelpLocations(options, name); List<HelpLocation> nestedHelp = getParentHelpLocations(options, name);
for (HelpLocation help : nestedHelp) { for (HelpLocation help : nestedHelp) {
if (help != null && !isValidHelpLocation(help)) { if (help != null && !isValidHelpLocation(help)) {
missing.add("Bad help location: " + help.toString()); missing.add("Bad parent help for path: " + options.getName() + "." + name +
"; help: " + help.toString() + "\nMake sure your options parent node " +
"has a help location set, in addition to the individual options " +
"node");
} }
} }
// it has a help location; is it valid? // it has a help location; is it valid?
if (hl != null && !isValidHelpLocation(hl)) { if (hl != null && !isValidHelpLocation(hl)) {
isValidHelpLocation(hl);
missing.add(options.getName() + "." + name); missing.add(options.getName() + "." + name);
} }
} }