From b0e55733c17c4a3b8a9cc2161c4fb9ee6b9a411d Mon Sep 17 00:00:00 2001 From: ghidra1 Date: Thu, 27 Jan 2022 17:01:25 -0500 Subject: [PATCH] GP-0 Make FIDAnalyzer options names public to avoid hard coded strings in tests and scripts --- .../java/ghidra/feature/fid/analyzer/FidAnalyzer.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Ghidra/Features/FunctionID/src/main/java/ghidra/feature/fid/analyzer/FidAnalyzer.java b/Ghidra/Features/FunctionID/src/main/java/ghidra/feature/fid/analyzer/FidAnalyzer.java index 65b130f24f..aeabd0b6ea 100644 --- a/Ghidra/Features/FunctionID/src/main/java/ghidra/feature/fid/analyzer/FidAnalyzer.java +++ b/Ghidra/Features/FunctionID/src/main/java/ghidra/feature/fid/analyzer/FidAnalyzer.java @@ -38,11 +38,11 @@ public class FidAnalyzer extends AbstractAnalyzer { private FidService service; // Options - private static final String OPTION_NAME_CREATE_BOOKMARKS = "Create Analysis Bookmarks"; + public static final String OPTION_NAME_CREATE_BOOKMARKS = "Create Analysis Bookmarks"; private static final String OPTION_DESCRIPTION_CREATE_BOOKMARKS = "If checked, an analysis bookmark will be created for each function which was matched " + "against one or more known library functions."; - private static final String APPLY_ALL_FID_LABELS_OPTION_NAME = "Always apply FID labels"; + public static final String APPLY_ALL_FID_LABELS_OPTION_NAME = "Always apply FID labels"; private static final String APPLY_ALL_FID_LABELS_OPTION_DESCRIPTION = "Enable this option to " + "always apply FID labels at functions regardless of existing labels at that function." + " When enabled, FID labels will always be added." + @@ -57,13 +57,13 @@ public class FidAnalyzer extends AbstractAnalyzer { private boolean alwaysApplyFidLabels = APPLY_ALL_FID_LABELS_DEFAULT; private boolean createBookmarksEnabled = OPTION_DEFAULT_CREATE_BOOKMARKS_ENABLED; - private static final String SCORE_THRESHOLD_OPTION_NAME = "Instruction count threshold"; + public static final String SCORE_THRESHOLD_OPTION_NAME = "Instruction count threshold"; private static final String SCORE_THRESHOLD_OPTION_DESCRIPTION = "The minimum score that a potential match must meet to be labeled by the analyzer. " + "Score corresponds roughly to the number of instructions in the function."; private float scoreThreshold; - private static final String MULTIMATCH_THRESHOLD_OPTION_NAME = "Multiple match threshold"; + public static final String MULTIMATCH_THRESHOLD_OPTION_NAME = "Multiple match threshold"; private static final String MULTIMATCH_THRESHOLD_OPTION_DESCRIPTION = "If there are multiple conflicting matches for a function, its score must exceed " + "this secondary threshold in order to be labeled by the analyzer";