From b4bae21b6569853f94b9ff8f878da827c74cfab6 Mon Sep 17 00:00:00 2001 From: ghidorahrex Date: Wed, 28 Aug 2019 12:52:46 -0400 Subject: [PATCH] GT-3052: Code review comments --- .../Processors/HCS08/certification.manifest | 4 +- .../HCS08/data/languages/HC05-M68HC05TB.pspec | 60 +++++ .../HCS08/data/languages/HC05.ldefs | 12 + .../HCS08/data/languages/HC05.pspec | 39 +-- .../data/languages/HC08-MC68HC908QY4.pspec | 127 +++++++++ .../HCS08/data/languages/HC08.ldefs | 12 + .../HCS08/data/languages/HC08.pspec | 112 +------- .../data/languages/HCS08-MC9S08GB60.pspec | 244 ++++++++++++++++++ .../HCS08/data/languages/HCS08.ldefs | 12 + .../HCS08/data/languages/HCS08.pspec | 216 ---------------- 10 files changed, 477 insertions(+), 361 deletions(-) create mode 100644 Ghidra/Processors/HCS08/data/languages/HC05-M68HC05TB.pspec create mode 100644 Ghidra/Processors/HCS08/data/languages/HC08-MC68HC908QY4.pspec create mode 100644 Ghidra/Processors/HCS08/data/languages/HCS08-MC9S08GB60.pspec diff --git a/Ghidra/Processors/HCS08/certification.manifest b/Ghidra/Processors/HCS08/certification.manifest index b3f96b57bd..7b1c0a9601 100644 --- a/Ghidra/Processors/HCS08/certification.manifest +++ b/Ghidra/Processors/HCS08/certification.manifest @@ -2,13 +2,15 @@ .project||GHIDRA||||END| Module.manifest||GHIDRA||||END| build.gradle||GHIDRA||||END| -data/build.xml||GHIDRA||||END| +data/languages/HC05-M68HC05TB.pspec||GHIDRA||||END| data/languages/HC05.ldefs||GHIDRA||||END| data/languages/HC05.pspec||GHIDRA||||END| data/languages/HC05.slaspec||GHIDRA||||END| +data/languages/HC08-MC68HC908QY4.pspec||GHIDRA||||END| data/languages/HC08.ldefs||GHIDRA||||END| data/languages/HC08.pspec||GHIDRA||||END| data/languages/HC08.slaspec||GHIDRA||||END| +data/languages/HCS08-MC9S08GB60.pspec||GHIDRA||||END| data/languages/HCS08.cspec||GHIDRA||||END| data/languages/HCS08.ldefs||GHIDRA||||END| data/languages/HCS08.opinion||GHIDRA||||END| diff --git a/Ghidra/Processors/HCS08/data/languages/HC05-M68HC05TB.pspec b/Ghidra/Processors/HCS08/data/languages/HC05-M68HC05TB.pspec new file mode 100644 index 0000000000..ba3c607c46 --- /dev/null +++ b/Ghidra/Processors/HCS08/data/languages/HC05-M68HC05TB.pspec @@ -0,0 +1,60 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/Ghidra/Processors/HCS08/data/languages/HC05.ldefs b/Ghidra/Processors/HCS08/data/languages/HC05.ldefs index 0f8e08d4d3..4caea38800 100644 --- a/Ghidra/Processors/HCS08/data/languages/HC05.ldefs +++ b/Ghidra/Processors/HCS08/data/languages/HC05.ldefs @@ -13,4 +13,16 @@ HC05 (6805) Microcontroller Family + + HC05 (6805) Microcontroller Family - M68HC05TB + + diff --git a/Ghidra/Processors/HCS08/data/languages/HC05.pspec b/Ghidra/Processors/HCS08/data/languages/HC05.pspec index ffb0f57527..1b96212e9a 100644 --- a/Ghidra/Processors/HCS08/data/languages/HC05.pspec +++ b/Ghidra/Processors/HCS08/data/languages/HC05.pspec @@ -11,47 +11,20 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + diff --git a/Ghidra/Processors/HCS08/data/languages/HC08-MC68HC908QY4.pspec b/Ghidra/Processors/HCS08/data/languages/HC08-MC68HC908QY4.pspec new file mode 100644 index 0000000000..c7febf3805 --- /dev/null +++ b/Ghidra/Processors/HCS08/data/languages/HC08-MC68HC908QY4.pspec @@ -0,0 +1,127 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/Ghidra/Processors/HCS08/data/languages/HC08.ldefs b/Ghidra/Processors/HCS08/data/languages/HC08.ldefs index 42aaadb002..1213b4c1fa 100644 --- a/Ghidra/Processors/HCS08/data/languages/HC08.ldefs +++ b/Ghidra/Processors/HCS08/data/languages/HC08.ldefs @@ -13,4 +13,16 @@ HC08 Microcontroller Family + + HC08 Microcontroller Family - MC68HC908QY4 + + diff --git a/Ghidra/Processors/HCS08/data/languages/HC08.pspec b/Ghidra/Processors/HCS08/data/languages/HC08.pspec index 2b7d149f1c..77be20c223 100644 --- a/Ghidra/Processors/HCS08/data/languages/HC08.pspec +++ b/Ghidra/Processors/HCS08/data/languages/HC08.pspec @@ -4,124 +4,14 @@ --> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/Ghidra/Processors/HCS08/data/languages/HCS08-MC9S08GB60.pspec b/Ghidra/Processors/HCS08/data/languages/HCS08-MC9S08GB60.pspec new file mode 100644 index 0000000000..0cd50bdfe3 --- /dev/null +++ b/Ghidra/Processors/HCS08/data/languages/HCS08-MC9S08GB60.pspec @@ -0,0 +1,244 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/Ghidra/Processors/HCS08/data/languages/HCS08.ldefs b/Ghidra/Processors/HCS08/data/languages/HCS08.ldefs index 8a5f9c18c2..778ab667dc 100644 --- a/Ghidra/Processors/HCS08/data/languages/HCS08.ldefs +++ b/Ghidra/Processors/HCS08/data/languages/HCS08.ldefs @@ -13,4 +13,16 @@ HCS08 Microcontroller Family + + HCS08 Microcontroller Family - MC9S08GB60 + + diff --git a/Ghidra/Processors/HCS08/data/languages/HCS08.pspec b/Ghidra/Processors/HCS08/data/languages/HCS08.pspec index 75236d8005..4f0dc75024 100644 --- a/Ghidra/Processors/HCS08/data/languages/HCS08.pspec +++ b/Ghidra/Processors/HCS08/data/languages/HCS08.pspec @@ -4,183 +4,7 @@ --> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -195,50 +19,10 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -