yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-05 19:42:36 +02:00
Code Issues Releases Wiki Activity

GP-1418 changed caches to use LRUMap instead of HashMap so that the

Browse source 
cache will be limited to how much memory is uses.
This commit is contained in:
ghidravore 2021-10-19 17:38:38 -04:00 • committed by emteere
parent fce49f4c08
commit b69088138a
1 changed files with 15 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Ghidra/Features/Base/src/main/java/ghidra/program/util/SymbolicPropogator.java
View file

@ -18,6 +18,8 @@ package ghidra.program.util;
import java.math.BigInteger;
import java.util.*;
import org.apache.commons.collections4.map.LRUMap;
import generic.util.UnsignedDataUtils;
import ghidra.app.cmd.disassemble.DisassembleCommand;
import ghidra.app.cmd.function.CallDepthChangeInfo;
@ -38,7 +40,7 @@ import ghidra.util.exception.*;
import ghidra.util.task.TaskMonitor;
public class SymbolicPropogator {
private static int LRU_SIZE = 1024;
// QUESTIONS
// 1. How are "register-relative" varnodes distinguished based upon target space ? Not sure how we handle wrapping/truncation concerns.
// 1) The offset is the only thing that could be used as a reference.
@ -78,6 +80,18 @@ public class SymbolicPropogator {
protected static final int MAX_EXACT_INSTRUCTIONS = 100;
// Cache flows from instructions
Map<Address, Address[]> instructionFlowsCache = new LRUMap<>(LRU_SIZE);
// Cache PcodeOps so that we won't have to grab them again if we re-visit the node.
Map<Address, PcodeOp[]> pcodeCache = new LRUMap<>(LRU_SIZE);
// Cache Instructions looked up by At
Map<Address, Instruction> instructionAtCache = new LRUMap<>(LRU_SIZE);
// Cache instructions looked up by containing
Map<Address, Instruction> instructionContainingCache = new LRUMap<>(LRU_SIZE);
public SymbolicPropogator(Program program) {
this.program = program;
@ -684,10 +698,6 @@ public class SymbolicPropogator {
return false;
}
// Cache PcodeOps so that we won't have to grab them again if we re-visit the node.
//
HashMap<Address, PcodeOp[]> pcodeCache = new HashMap<>();
private PcodeOp[] getInstructionPcode(Instruction instruction) {
PcodeOp ops[] = pcodeCache.get(instruction.getMinAddress());
if (ops == null) {
@ -697,12 +707,6 @@ public class SymbolicPropogator {
return ops;
}
// Cache Instructions looked up by At
HashMap<Address, Instruction> instructionAtCache = new HashMap<>();
// Cache instructions looked up by containing
HashMap<Address, Instruction> instructionContainingCache = new HashMap<>();
private Instruction getInstructionAt(Address addr) {
Instruction instr = instructionAtCache.get(addr);
if (instr != null) {
@ -739,9 +743,6 @@ public class SymbolicPropogator {
return instr;
}
// Cache flows from instructions
HashMap<Address, Address[]> instructionFlowsCache = new HashMap<>();
private Address[] getInstructionFlows(Instruction instruction) {
Address addr = instruction.getMinAddress();