From b7e048df77b6f3ec1f64aa85730990e72b02076d Mon Sep 17 00:00:00 2001 From: Paul Sorensen Date: Tue, 30 Mar 2021 13:39:59 -0400 Subject: [PATCH] Fix idaxml set_member_cmt func call The script originally was incorrectly calling `idc.set_member_cmt` which takes different arguments to calculate the member struct and offset. And then it passes the results into the `ida_struct` version. However, this is already done, so we can just go straight to the `ida_struct` version. --- GhidraBuild/IDAPro/Python/7xx/python/idaxml.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/GhidraBuild/IDAPro/Python/7xx/python/idaxml.py b/GhidraBuild/IDAPro/Python/7xx/python/idaxml.py index 5a88be0742..0b7e8e67e6 100644 --- a/GhidraBuild/IDAPro/Python/7xx/python/idaxml.py +++ b/GhidraBuild/IDAPro/Python/7xx/python/idaxml.py @@ -3111,11 +3111,11 @@ class XmlImporter(IdaXml): """ regcmt = member.find(REGULAR_CMT) if regcmt != None: - idc.set_member_cmt(mbr, regcmt.text, False) + ida_struct.set_member_cmt(mbr, regcmt.text, False) self.update_counter(MEMBER + ':' + REGULAR_CMT) rptcmt = member.find(REPEATABLE_CMT) if rptcmt != None: - idc.set_member_cmt(mbr, rptcmt.text, True) + ida_struct.set_member_cmt(mbr, rptcmt.text, True) self.update_counter(MEMBER + ':' + REPEATABLE_CMT)