GT-2869 - Shared Key Bindings - review fixes

This commit is contained in:
dragonmacher 2019-06-03 17:52:35 -04:00
parent 5a9067832a
commit c1de98304a
17 changed files with 23 additions and 43 deletions

View file

@ -66,8 +66,7 @@ public abstract class AbstractFindReferencesDataTypeAction extends DockingAction
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -43,8 +43,7 @@ public class CycleGroupAction extends CompositeEditorTableAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -54,8 +54,7 @@ public class ChooseDataTypeAction extends DockingAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -58,8 +58,7 @@ class CreateArrayAction extends DockingAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -53,8 +53,7 @@ public class CycleGroupAction extends DockingAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -68,8 +68,7 @@ class DataAction extends ListingContextAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
DataType getDataType() {

View file

@ -54,8 +54,7 @@ public class ChooseDataTypeAction extends DockingAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -51,8 +51,7 @@ class CreateArrayAction extends ListingContextAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -53,8 +53,7 @@ public class CycleGroupAction extends ListingContextAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -66,8 +66,7 @@ class DataAction extends ListingContextAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
void setPopupMenu(String name, boolean isSignatureAction) {

View file

@ -51,8 +51,7 @@ public class FindReferencesToAction extends ListingContextAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -646,8 +646,7 @@ class GhidraScriptActionManager {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -73,8 +73,7 @@ public class ShowSymbolReferencesAction extends SymbolTreeContextAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -90,8 +90,7 @@ public class DeleteTableRowAction extends DockingAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override

View file

@ -54,8 +54,7 @@ public abstract class MakeProgramSelectionAction extends DockingAction {
return;
}
// we don't have a default keybinding, so any value implies user-defined
setUnvalidatedKeyBindingData(new KeyBindingData(keyStroke));
setKeyBindingData(new KeyBindingData(keyStroke));
}
@Override