yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-03 17:59:46 +02:00
Code Issues Releases Wiki Activity

Merge remote-tracking branch 'origin/GP-1750_Dan_dbTraceDeadlock' into patch

Browse source
This commit is contained in:
Ryan Kurtz 2022-03-22 12:23:04 -04:00
commit c6b5149d27
1 changed files with 40 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

68
Ghidra/Debug/Framework-TraceModeling/src/main/java/ghidra/trace/util/DefaultTraceTimeViewport.java
View file

@ -186,12 +186,14 @@ public class DefaultTraceTimeViewport implements TraceTimeViewport {
} }
protected boolean isLower(long lower) { protected boolean isLower(long lower) {
synchronized (ordered) { try (LockHold hold = trace.lockRead()) { // May not be necessary
Range<Long> range = spanSet.rangeContaining(lower); synchronized (ordered) {
if (range == null) { Range<Long> range = spanSet.rangeContaining(lower);
return false; if (range == null) {
return false;
}
return range.lowerEndpoint().longValue() == lower;
} }
return range.lowerEndpoint().longValue() == lower;
} }
} }
@ -262,12 +264,12 @@ public class DefaultTraceTimeViewport implements TraceTimeViewport {
List<Range<Long>> ordered = new ArrayList<>(); List<Range<Long>> ordered = new ArrayList<>();
try (LockHold hold = trace.lockRead()) { try (LockHold hold = trace.lockRead()) {
collectForkRanges(trace.getTimeManager(), snap, spanSet, ordered); collectForkRanges(trace.getTimeManager(), snap, spanSet, ordered);
} synchronized (this.ordered) {
synchronized (this.ordered) { this.spanSet.clear();
this.spanSet.clear(); this.ordered.clear();
this.ordered.clear(); this.spanSet.addAll(spanSet);
this.spanSet.addAll(spanSet); this.ordered.addAll(ordered);
this.ordered.addAll(ordered); }
} }
assert !ordered.isEmpty(); assert !ordered.isEmpty();
changeListeners.fire.run(); changeListeners.fire.run();
@ -322,41 +324,51 @@ public class DefaultTraceTimeViewport implements TraceTimeViewport {
@Override @Override
public boolean isForked() { public boolean isForked() {
synchronized (ordered) { try (LockHold hold = trace.lockRead()) { // May not be necessary
return ordered.size() > 1; synchronized (ordered) {
return ordered.size() > 1;
}
} }
} }
public List<Range<Long>> getOrderedSpans() { public List<Range<Long>> getOrderedSpans() {
synchronized (ordered) { try (LockHold hold = trace.lockRead()) { // May not be necessary
return List.copyOf(ordered); synchronized (ordered) {
return List.copyOf(ordered);
}
} }
} }
public List<Range<Long>> getOrderedSpans(long snap) { public List<Range<Long>> getOrderedSpans(long snap) {
synchronized (ordered) { try (LockHold hold = trace.lockRead()) { // setSnap requires this
setSnap(snap); synchronized (ordered) {
return getOrderedSpans(); setSnap(snap);
return getOrderedSpans();
}
} }
} }
@Override @Override
public List<Long> getOrderedSnaps() { public List<Long> getOrderedSnaps() {
synchronized (ordered) { try (LockHold hold = trace.lockRead()) { // May not be necessary
return ordered synchronized (ordered) {
.stream() return ordered
.map(Range::upperEndpoint) .stream()
.collect(Collectors.toList()); .map(Range::upperEndpoint)
.collect(Collectors.toList());
}
} }
} }
@Override @Override
public List<Long> getReversedSnaps() { public List<Long> getReversedSnaps() {
synchronized (ordered) { try (LockHold hold = trace.lockRead()) { // May not be necessary
return Lists.reverse(ordered) synchronized (ordered) {
.stream() return Lists.reverse(ordered)
.map(Range::upperEndpoint) .stream()
.collect(Collectors.toList()); .map(Range::upperEndpoint)
.collect(Collectors.toList());
}
} }
} }