yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-06 03:50:02 +02:00
Code Issues Releases Wiki Activity

Merge remote-tracking branch 'origin/GP-1-dragonmacher-graph-help'

Browse source
This commit is contained in:
Ryan Kurtz 2025-07-16 06:14:37 -04:00
commit cb762ea71e
6 changed files with 20 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Ghidra/Framework/Docking/src/main/java/docking/help/HelpManager.java
View file

@ -523,20 +523,28 @@ public class HelpManager implements HelpService {
public Map<Object, HelpLocation> getInvalidHelpLocations(TaskMonitor monitor)
throws CancelledException {
Set<String> alreadySeen = new HashSet<>();
Map<Object, HelpLocation> map = new WeakHashMap<>();
Map<Object, HelpLocation> helpLocationsCopy = copyHelpLocations();
monitor.initialize(helpLocationsCopy.size());
Set<Entry<Object, HelpLocation>> entries = helpLocationsCopy.entrySet();
for (Entry<Object, HelpLocation> entry : entries) {
monitor.checkCancelled();
monitor.increment();
Object helpee = entry.getKey();
HelpLocation location = entry.getValue();
monitor.setMessage("Checking " + helpee);
if (!hasValidHelp(helpee, location)) {
map.put(helpee, location);
if (hasValidHelp(helpee, location)) {
continue;
}
monitor.incrementProgress(1);
String inception = location.getInceptionInformation();
if (alreadySeen.contains(inception)) {
continue; // don't show repeated errors for same line of code
}
alreadySeen.add(inception);
map.put(helpee, location);
}
return map;
}