From 066ce5f71b0ee9fed2bc61333532c2100e0e8eda Mon Sep 17 00:00:00 2001 From: ghidorahrex Date: Thu, 16 Nov 2023 16:04:40 +0000 Subject: [PATCH 1/2] GP-4046: Fixed sleigh pattern constraint example --- GhidraDocs/languages/html/sleigh_constructors.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GhidraDocs/languages/html/sleigh_constructors.html b/GhidraDocs/languages/html/sleigh_constructors.html index 0613c35bb7..c943e2ac3b 100644 --- a/GhidraDocs/languages/html/sleigh_constructors.html +++ b/GhidraDocs/languages/html/sleigh_constructors.html @@ -629,7 +629,7 @@ if, when all the variables are evaluated, the equation is true. 

 :xor r1,r2 is opcode=0xcd & r1 & r2 { r1 = r1 ^ r2; }
-:clr r1    is opcode=0xcd & r1 & r2=r1 { r1 = 0; }
+:clr r1    is opcode=0xcd & r1 & r1=r2 { r1 = 0; }

From 27381f9283b7a77979e0e5b366c2d520ba99a179 Mon Sep 17 00:00:00 2001 From: ghidorahrex Date: Wed, 29 Nov 2023 16:20:31 +0000 Subject: [PATCH 2/2] GP-4046: review fix --- GhidraDocs/languages/html/sleigh_constructors.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/GhidraDocs/languages/html/sleigh_constructors.html b/GhidraDocs/languages/html/sleigh_constructors.html index c943e2ac3b..3b4dde0a97 100644 --- a/GhidraDocs/languages/html/sleigh_constructors.html +++ b/GhidraDocs/languages/html/sleigh_constructors.html @@ -645,10 +645,10 @@ feature of clr from xor, are equal. The easiest way to specify this special case is with the general constraint, -“r2 = r1”, as in the second +“r1 = r2”, as in the second line of the example. The SLEIGH compiler will implement this by -enumerating all the cases where r2 -equals r1, creating as many states as there are +enumerating all the cases where r1 +equals r2, creating as many states as there are registers. But the specification itself, at least, remains compact.