yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-06 03:50:02 +02:00
Code Issues Releases Wiki Activity

GT-3197 - Call Trees - review fixes

Browse source 
Fixes #1087
This commit is contained in:
dragonmacher 2019-10-03 12:02:35 -04:00
parent ea8e2a81c6
commit da90d2f800
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Ghidra/Features/Base/src/main/help/help/topics/CallTreePlugin/Call_Tree_Plugin.html
View file

@ -45,7 +45,7 @@
<UL>
<LI>
When launched from the toolbar icon, the provider that is shown will track the
current location in the Listing (the the <IMG src="images/locationIn.gif" border="1">
current location in the Listing (the <IMG src="images/locationIn.gif" border="1">
<A href="#Call_Tree_Action_Incoming_Navigation">Navigate on Incoming Location Changes
button</A> is on).
</LI>

4
Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/calltree/CallTreePlugin.java
View file

@ -111,8 +111,8 @@ public class CallTreePlugin extends ProgramPlugin {
CallTreeProvider findTransientProviderForLocation(ProgramLocation location) {
for (CallTreeProvider provider : providers) {
if (provider == primaryProvider) {
continue; // not transient
if (!provider.isTransient()) {
continue;
}
if (provider.isShowingLocation(location)) {

2
Ghidra/Framework/Docking/src/main/java/docking/help/GHelpHTMLEditorKit.java
View file

@ -397,7 +397,7 @@ public class GHelpHTMLEditorKit extends HTMLEditorKit {
* anything.
*
* To get the base class to use our image, we override getImage(). However, we should
* only return our image when the base class is finished loaded. (See the base class'
* only return our image when the base class is finished loading. (See the base class'
* paint() method for why we need to do this.)
*
* Note: if we start seeing unusual behavior, like images not rendering, or any size