Miscellanious bug fixes and code clean up.

This commit is contained in:
ghidravore 2020-09-30 17:31:17 -04:00
parent 480cbcfafd
commit e72b79a239
13 changed files with 405 additions and 346 deletions

View file

@ -30,7 +30,7 @@ public class DummyGraphDisplayListener implements GraphDisplayListener {
}
@Override
public void locationChanged(String vertexId) {
public void locationFocusChanged(String vertexId) {
// I'm a dummy
}

View file

@ -17,6 +17,7 @@ package ghidra.service.graph;
import java.util.List;
import docking.widgets.EventTrigger;
import ghidra.util.exception.CancelledException;
import ghidra.util.task.TaskMonitor;
@ -41,18 +42,31 @@ public interface GraphDisplay {
public void setGraphDisplayListener(GraphDisplayListener listener);
/**
* Tells the graph display window to focus
* Tells the graph display window to focus the vertex with the given id.
*
* @param vertexID the id of the vertex to focus
* @param eventTrigger Provides a hint to the GraphDisplay as to why we are updating the
* graph location so that the GraphDisplay can decide if it should send out a notification via
* the {@link GraphDisplayListener#locationFocusChanged(String)}. For example, if we are updating
* the the location due to an event from the main application, we don't want to notify the
* application the graph changed to avoid event cycles. See {@link EventTrigger} for more
* information.
*
*/
public void setLocation(String vertexID);
public void setLocationFocus(String vertexID, EventTrigger eventTrigger);
/**
* Tells the graph display window to select the vertices with the given ids
*
* @param vertexList the list of vertex ids to select
* @param eventTrigger Provides a hint to the GraphDisplay as to why we are updating the
* graph location so that the GraphDisplay can decide if it should send out a notification via
* the {@link GraphDisplayListener#locationFocusChanged(String)}. For example, if we are updating
* the the location due to an event from the main application, we don't want to notify the
* application the graph changed to avoid event cycles. See {@link EventTrigger} for more
* information.
*/
public void selectVertices(List<String> vertexList);
public void selectVertices(List<String> vertexList, EventTrigger eventTrigger);
/**
* Closes this graph display window.
@ -103,7 +117,7 @@ public interface GraphDisplay {
/**
* Updates a vertex to a new name
* @param id the vertix id
* @param id the vertex id
* @param newName the new name of the vertex
*/
public void updateVertexName(String id, String newName);

View file

@ -37,7 +37,7 @@ public interface GraphDisplayListener {
* Notification that the "focused" (active) vertex has changed.
* @param vertexId the vertex id of the currently "focused" vertex
*/
public void locationChanged(String vertexId);
public void locationFocusChanged(String vertexId);
default boolean updateVertexName(String vertexId, String oldName, String newName) {
// no op