From f29fb24ee8b05d78f449f337b8e8d98dfb363fd8 Mon Sep 17 00:00:00 2001 From: Sullivan DeVries Date: Tue, 1 Apr 2025 17:23:24 -0700 Subject: [PATCH] GP-5558: fixed ndata post-increment instead of pre-increment causing return case to be missed (Closes #7973, Closes #7974) --- .../java/ghidra/app/util/bin/format/pe/OptionalHeaderImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/pe/OptionalHeaderImpl.java b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/pe/OptionalHeaderImpl.java index 6bc10bb780..56a2e19e3d 100644 --- a/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/pe/OptionalHeaderImpl.java +++ b/Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/pe/OptionalHeaderImpl.java @@ -394,7 +394,7 @@ public class OptionalHeaderImpl implements OptionalHeader { throw re; } } - if (ndata++ == numberOfRvaAndSizes) { + if (++ndata == numberOfRvaAndSizes) { return; }