yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-03 09:49:23 +02:00
Code Issues Releases Wiki Activity

Merge remote-tracking branch 'origin/GP-0-dragonmacher-test-fixes-4-18-25'

Browse source
This commit is contained in:
Ryan Kurtz 2025-04-18 13:07:29 -04:00
commit f65a993d26
2 changed files with 14 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/cparser/ParseDialog.java
View file

@ -518,6 +518,11 @@ class ParseDialog extends ReusableDialogComponentProvider {
public void actionPerformed(ActionContext context) { public void actionPerformed(ActionContext context) {
saveAs((ComboBoxItem) comboBox.getSelectedItem()); saveAs((ComboBoxItem) comboBox.getSelectedItem());
} }
@Override
public boolean isEnabledForContext(ActionContext context) {
return true;
}
}; };
icon = Icons.SAVE_AS_ICON; icon = Icons.SAVE_AS_ICON;
saveAsAction.setMenuBarData(new MenuData(new String[] { "Save As..." }, icon, saveGroup)); saveAsAction.setMenuBarData(new MenuData(new String[] { "Save As..." }, icon, saveGroup));

16
Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/cparser/ParseDialogTest.java
View file

@ -26,6 +26,7 @@ import javax.swing.table.TableModel;
import org.junit.*; import org.junit.*;
import docking.ActionContext;
import docking.action.DockingActionIf; import docking.action.DockingActionIf;
import docking.widgets.OptionDialog; import docking.widgets.OptionDialog;
import docking.widgets.dialogs.InputDialog; import docking.widgets.dialogs.InputDialog;
@ -115,20 +116,21 @@ public class ParseDialogTest extends AbstractGhidraHeadedIntegrationTest {
JButton parseToFileButton = findButtonByText(dialog, "Parse to File..."); JButton parseToFileButton = findButtonByText(dialog, "Parse to File...");
assertNotNull(parseToFileButton); assertNotNull(parseToFileButton);
ActionContext context = dialog.getActionContext(null);
DockingActionIf saveAsAction = getAction(dialog, "Save Profile As"); DockingActionIf saveAsAction = getAction(dialog, "Save Profile As");
assertTrue(saveAsAction.isEnabled()); assertTrue(saveAsAction.isEnabledForContext(context));
DockingActionIf saveAction = getAction(dialog, "Save Profile"); DockingActionIf saveAction = getAction(dialog, "Save Profile");
assertFalse(saveAction.isEnabled()); assertFalse(saveAction.isEnabledForContext(context));
DockingActionIf clearAction = getAction(dialog, "Clear Profile"); DockingActionIf clearAction = getAction(dialog, "Clear Profile");
assertTrue(clearAction.isEnabled()); assertTrue(clearAction.isEnabledForContext(context));
DockingActionIf deleteAction = getAction(dialog, "Delete Profile"); DockingActionIf deleteAction = getAction(dialog, "Delete Profile");
assertFalse(deleteAction.isEnabled()); assertFalse(deleteAction.isEnabledForContext(context));
DockingActionIf refreshAction = getAction(dialog, "Refresh User Profiles"); DockingActionIf refreshAction = getAction(dialog, "Refresh User Profiles");
assertTrue(refreshAction.isEnabled()); assertTrue(refreshAction.isEnabledForContext(context));
} }
@Test @Test
@ -137,10 +139,10 @@ public class ParseDialogTest extends AbstractGhidraHeadedIntegrationTest {
addSourceFile("c:\\temp\\fred.h"); addSourceFile("c:\\temp\\fred.h");
DockingActionIf saveAction = getAction(dialog, "Save Profile"); DockingActionIf saveAction = getAction(dialog, "Save Profile");
assertFalse(saveAction.isEnabled()); assertFalse(saveAction.isEnabledForContext(dialog.getActionContext(null)));
DockingActionIf saveAsAction = getAction(dialog, "Save Profile As"); DockingActionIf saveAsAction = getAction(dialog, "Save Profile As");
assertTrue(saveAsAction.isEnabled()); assertTrue(saveAsAction.isEnabledForContext(dialog.getActionContext(null)));
} }
@Test @Test