yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-05 19:42:36 +02:00
Code Issues Releases Wiki Activity

GP-1111 corrected affected test and help docs

Browse source
This commit is contained in:
ghidra1 2021-08-03 11:29:16 -04:00
parent 9ee192dbe9
commit f72d679eff
2 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Ghidra/Features/Base/src/main/help/help/topics/DataTypeEditors/StructureEditor.htm
View file

@ -631,7 +631,18 @@
does this by selecting the components in the editor and clicking the <IMG src=
"images/cstruct.png" alt=""> <B>Create Structure From Selection</B> button. The user is then
prompted for the name of the new structure. Once a unique name is specified the new structure
is created and a component containing it replaces the selected components.</P>
is created and a component containing it replaces the selected components. The newly created
structure will adopt the same pack setting as the current structure.</P>
<P>It is important to note that when using this action with a packed structure the placement of components
within the new stucture may change as can offsets of trailing components within the current structure.
The size of the current structure may also be affected as a result of this change.</P>
<P>If you do not like the result of the change you can restore the previous state of the
current structure by using the <A HREF="#Structure_Editor_Unpackage_Component"></A> action on
the new structure component, although the newly created structure will still exist within
the Data Type Manager.</P>
</BLOCKQUOTE><BR>
</BLOCKQUOTE>

6
Ghidra/Features/Base/src/test.slow/java/ghidra/app/plugin/core/compositeeditor/StructureEditorLockedActions2Test.java
View file

@ -307,10 +307,10 @@ public class StructureEditorLockedActions2Test extends AbstractStructureEditorLo
assertTrue(internalDt0.isEquivalent(originalDt1));
assertTrue(internalDt1.isEquivalent(originalDt2));
assertTrue(internalDt2.isEquivalent(originalDt3));
assertEquals(14, getDataType(1).getLength());
assertEquals(14, getModel().getComponent(1).getLength());
assertEquals(16, getDataType(1).getLength());
assertEquals(16, getModel().getComponent(1).getLength());
assertEquals(originalDt4, getDataType(2));
assertEquals(32, getModel().getLength());
assertEquals(36, getModel().getLength());
}
/**