From fd3e835be5515068b843cc25f87f23fda8ff8afc Mon Sep 17 00:00:00 2001 From: dev747368 <48332326+dev747368@users.noreply.github.com> Date: Fri, 10 Jul 2020 13:34:43 -0400 Subject: [PATCH] GP-29 - commented the change per code review --- .../main/projectdata/actions/VersionControlAddAction.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Ghidra/Framework/Project/src/main/java/ghidra/framework/main/projectdata/actions/VersionControlAddAction.java b/Ghidra/Framework/Project/src/main/java/ghidra/framework/main/projectdata/actions/VersionControlAddAction.java index bd158f5789..ca89957324 100644 --- a/Ghidra/Framework/Project/src/main/java/ghidra/framework/main/projectdata/actions/VersionControlAddAction.java +++ b/Ghidra/Framework/Project/src/main/java/ghidra/framework/main/projectdata/actions/VersionControlAddAction.java @@ -90,8 +90,8 @@ public class VersionControlAddAction extends VersionControlAction { if (unversioned.isEmpty()) { return; } - ArrayList list = new ArrayList(); - ArrayList changedList = new ArrayList(); + ArrayList list = new ArrayList<>(); + ArrayList changedList = new ArrayList<>(); for (DomainFile domainFile : unversioned) { if (domainFile.isBusy()) { Msg.showWarn(getClass(), null, "Add To Version Control Failed!", @@ -152,7 +152,9 @@ public class VersionControlAddAction extends VersionControlAction { return; } + // Note: this used to be a sleep(200) Swing.allowSwingToProcessEvents(); + df.addToVersionControl(comments, keepCheckedOut, monitor); } }