yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-04 10:19:23 +02:00
Code Issues Releases Wiki Activity

decompiler-cpp: Add missing for-loop index variable check

Browse source 
Prevent indexing out of bounds
This commit is contained in:
Eric Kilmer 2024-03-30 18:46:16 -04:00 • committed by caheckman
parent 2a7897c366
commit fdde0743e0
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Ghidra/Features/Decompiler/src/decompile/cpp/ifacedecomp.cc
View file

@ -4,9 +4,9 @@
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
* You may obtain a copy of the License at * You may obtain a copy of the License at
* *
* http://www.apache.org/licenses/LICENSE-2.0 * http://www.apache.org/licenses/LICENSE-2.0
* *
* Unless required by applicable law or agreed to in writing, software * Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, * distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@ -1844,7 +1844,7 @@ void IfcProtooverride::execute(istream &s)
s >> ws; s >> ws;
Address callpoint(parse_machaddr(s,discard,*dcp->conf->types)); Address callpoint(parse_machaddr(s,discard,*dcp->conf->types));
int4 i; int4 i;
for(i=0;dcp->fd->numCalls();++i) for(i=0;i<dcp->fd->numCalls();++i)
if (dcp->fd->getCallSpecs(i)->getOp()->getAddr() == callpoint) break; if (dcp->fd->getCallSpecs(i)->getOp()->getAddr() == callpoint) break;
if (i == dcp->fd->numCalls()) if (i == dcp->fd->numCalls())
throw IfaceExecutionError("No call is made at this address"); throw IfaceExecutionError("No call is made at this address");