Commit graph

728 commits

Author SHA1 Message Date
dragonmacher
638befbfd1 GT-3461 - fix for recent drag-n-drop break 2020-01-15 18:06:44 -05:00
dev747368
66fc367b18 GT-3414 revert Iterable change. 2020-01-15 13:23:44 -05:00
dev747368
5a66f68e47 GT-3414 code review, unit tests for DefinedDataIterator. 2020-01-15 13:15:13 -05:00
dev747368
4fbbe989be GT-3414, issue #1259 - fix GUI lockup when defined strings table loads
A large binary with lots of strings can cause the "Defined Strings"
table to fight with the Listing view over database locks.

This change eases some of the issues by making the defined strings table
be nicer by yielding to the swing thread before starting its query loop
(which allows a Listing view which is also doing its full rendering at
the same time to finish before the loop starts) and making the
DefinedDataIterator a bit smarter about what elements it needs to
recurse into.

The Listing can still be quite a bit laggy when the Defined Strings
table is loading.

Also fixed a logic error in StringDataInstance that caused it to return
a empty string for arrays of character elements.
2020-01-15 13:15:11 -05:00
ghidorahrex
4d29a3820d Merge remote-tracking branch 'origin/GT-3330_dev747368_DWARF_relocated_addresses_mode' 2020-01-15 13:00:14 -05:00
ghidorahrex
84fda704b0 Merge remote-tracking branch 'origin/GT-3347_dev747368_PR-1241_agatti_convert_char_seq' 2020-01-15 09:44:27 -05:00
dev747368
3718edc935 GT-3347 string / charsequences code review fixes
Fixed problem with picking between ArrayStringable elements and char
sequence for the string layout.
2020-01-14 18:32:15 -05:00
ghidorahrex
38a533c899 Merge remote-tracking branch
'origin/GT-3438-dragonmacher-vt-function-instruction-exception'

Fixes #1352
2020-01-13 13:21:31 -05:00
dragonmacher
8ebfd61348 GT-3446 - Review fixes 2020-01-10 18:52:47 -05:00
dragonmacher
142ed19e84 GT-3446 - Added key binding to trigger the Show Xrefs dialog 2020-01-10 17:13:01 -05:00
Ryan Kurtz
4c34b1e5b7 GT-3376: Review fixes 2020-01-10 09:19:25 -05:00
Ryan Kurtz
73b018fd84 GT-3376: Design improvements 2020-01-10 08:02:57 -05:00
Ryan Kurtz
a46e788706 GT-3376: Headless now properly honors -processor flag, even if the
specified processor is not a valid opinion.
2020-01-10 08:02:54 -05:00
ghidravore
3c2c23d8ce GT-3440 fixed bug where finding words in strings wasn't handling tabs
correctly
2020-01-09 13:07:04 -05:00
Ryan Kurtz
b487ce7eba Improved documentation of ByteProvider classes 2020-01-09 08:58:37 -05:00
Ryan Kurtz
d2db19cff7 Methods in headless were wrongly synchronized. Could lead to deadlock. 2020-01-09 08:05:27 -05:00
Ryan Kurtz
14b1e663f0 Merge remote-tracking branch 'origin/GT-2229_adamopolous_function-comparison-fixes' 2020-01-08 09:40:22 -05:00
Ryan Kurtz
7bf041cd9d Merge remote-tracking branch
'origin/GT-3439-dragonmacher-script-bookmark-docs' (fixes #1291)
2020-01-08 09:36:15 -05:00
Ryan Kurtz
81f6750f76 Merge remote-tracking branch
'origin/GT-3437-dragonmacher-vt-options-exception' (fixes #1143)
2020-01-08 09:35:13 -05:00
Ryan Kurtz
068a2f455e Merge remote-tracking branch 'origin/GT-3432-dragonmacher-drag-n-drop'
(fixes #1396)
2020-01-08 09:34:07 -05:00
dragonmacher
b34091b244 GT-3439 - Fixed javadoc for createBookmark() 2020-01-03 19:30:44 -05:00
dragonmacher
b9143a6265 GT-3438 - Version Tracking - removed exception being thrown by the Exact
Function Instructions Match correlator when the number of instructions
of the functions differed.
2020-01-03 18:19:18 -05:00
dragonmacher
fe18fff635 GT-3437 - Version Tracking - fixed exception when changing options
without a comparison loaded
2020-01-03 17:54:57 -05:00
dragonmacher
68de43307e GT-3436 - Fixed symbol tree navigation - review fixes 2020-01-03 17:38:27 -05:00
dragonmacher
14ee95c395 GT-3436 - Fixed symbol tree navigation to work on already selected node 2020-01-03 17:19:27 -05:00
dragonmacher
adbbc25542 GT-3432 - Fixed recently broken drag-n-drop from the Front End to a
running Tool
2020-01-03 15:42:21 -05:00
adamopolous
496408f2b7 GT-2999: fixed how comparison action is set to SHARED 2020-01-03 14:56:31 -05:00
dragonmacher
ec7773b464 GT-2229 - Function Comparison - updated screenshots 2020-01-03 14:55:24 -05:00
dragonmacher
94e17242ee GT-2229 - Function Comparison - screenshot library fixup 2020-01-03 14:55:23 -05:00
adamopolous
8c0b5c6a2b GT-2229: small test fixes 2020-01-03 14:55:23 -05:00
adamopolous
ff551599de GT-2229: added test for function delete 2020-01-03 14:55:22 -05:00
adamopolous
a682ef31ea added domain object listener for function remove events 2020-01-03 14:55:21 -05:00
Ryan Kurtz
f103e1c334 GT-3433: Fixed exception in PeLoader that occurred when creating a
memory block for a section when the section size exceeded the file size
(fixes #1371)
2020-01-02 13:04:55 -05:00
dragonmacher
74b67be5ed GT-3430 - Key Bindings - Updated the Function Call Trees Plugin's
actions key bindings so users can set the bindings separately
2019-12-30 12:02:46 -05:00
Ryan Kurtz
cbe5b9e9ca Merge remote-tracking branch
'origin/GT-3411-dragonmacher-dt-keybindings' (fixes #1355)
2019-12-27 13:04:18 -05:00
dev747368
3faebfebe8 GT-3347 - code cleanup, code review
Unify char representation and string representation code paths.
Add CHAR_SEQ string layout enum.
Misc javadocs.
2019-12-23 16:02:13 -05:00
dev747368
603ca28c01 GT-3347 - code review tweaks
Handle bitfields formatted as char.
Change how endianness affects display of char sequences in data
elements.
2019-12-23 15:57:57 -05:00
dev747368
73155ce499 GT-3347, PR #1241 - fix convert to char sequence menu item
Finish up integrating fixes for convert to char sequence, make
everything use StringDataInstance instead of StringUtils.toQuoteString.

Fix StringRenderBuilder to use '\x' for ASCII range escape sequences
(was using 2 byte wide for ASCII escape chars).
2019-12-23 15:57:57 -05:00
dev747368
14fbdee764 GT-3330 code review javadoc fix 2019-12-23 15:44:01 -05:00
dragonmacher
6a68e1f2dd Tests - fixed tests failing due to recent enum changes 2019-12-23 15:35:39 -05:00
dragonmacher
881dca75bf Tests - fixed tests failing to bad test mouse clicking and focus 2019-12-23 15:35:21 -05:00
dragonmacher
599728ec49 GT-3411 - Actions - fixed key bindings being removed from options after
tool restart
2019-12-23 11:09:21 -05:00
ghidra1
0f09cedffd Merge remote-tracking branch 'origin/patch'
Conflicts:
	Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/compositeeditor/BitFieldPlacementComponent.java
2019-12-20 17:29:11 -05:00
ghidra1
40d37fd7f4 GT-3410 eliminated use of getClipBounds 2019-12-20 17:23:22 -05:00
ghidra1
3ea8770bae GT-3415 Added mutability setting to enum datatypes as well as some code
cleanup.
2019-12-20 16:48:34 -05:00
astrelsky
d129dd6302
Fixed getRepeatableCommentAsRendered links 2019-12-19 18:15:37 -05:00
Ryan Kurtz
66172d136a Merge branch 'GT-3417_ryanmkurtz_PR-1248_snemes_repeatable' 2019-12-19 15:43:44 -05:00
Sandor Nemes
a36bb81faa Added 'setRepeatableComment', 'getRepeatableComment', and 'getRepeatableCommentAsRendered' to the top level Ghidra scripting env. 2019-12-19 21:33:22 +01:00
Ryan Kurtz
cf4328bda4 Merge remote-tracking branch
'origin/GT-3302-dragonmacher-front-end-ui-lockup'

Conflicts:
	Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/datamgr/DataTypeManagerPlugin.java
2019-12-19 15:30:21 -05:00
Jeremy Lacomis
e14d061e33 Fix "Propery" typos. 2019-12-19 13:00:59 -05:00