Commit graph

644 commits

Author SHA1 Message Date
dragonmacher
638befbfd1 GT-3461 - fix for recent drag-n-drop break 2020-01-15 18:06:44 -05:00
dev747368
66fc367b18 GT-3414 revert Iterable change. 2020-01-15 13:23:44 -05:00
dev747368
5a66f68e47 GT-3414 code review, unit tests for DefinedDataIterator. 2020-01-15 13:15:13 -05:00
dev747368
4fbbe989be GT-3414, issue #1259 - fix GUI lockup when defined strings table loads
A large binary with lots of strings can cause the "Defined Strings"
table to fight with the Listing view over database locks.

This change eases some of the issues by making the defined strings table
be nicer by yielding to the swing thread before starting its query loop
(which allows a Listing view which is also doing its full rendering at
the same time to finish before the loop starts) and making the
DefinedDataIterator a bit smarter about what elements it needs to
recurse into.

The Listing can still be quite a bit laggy when the Defined Strings
table is loading.

Also fixed a logic error in StringDataInstance that caused it to return
a empty string for arrays of character elements.
2020-01-15 13:15:11 -05:00
ghidorahrex
84fda704b0 Merge remote-tracking branch 'origin/GT-3347_dev747368_PR-1241_agatti_convert_char_seq' 2020-01-15 09:44:27 -05:00
dev747368
3718edc935 GT-3347 string / charsequences code review fixes
Fixed problem with picking between ArrayStringable elements and char
sequence for the string layout.
2020-01-14 18:32:15 -05:00
ghidravore
25cb235aaf Merge remote-tracking branch 'origin/GT-1-dragonmacher-documentation-fixup' 2020-01-14 18:24:48 -05:00
dragonmacher
d0dc082967 GT-1 - Documentation - review fix 2020-01-14 17:12:23 -05:00
ghidravore
04e49ee46a fixes to action builder 2020-01-14 14:50:41 -05:00
dragonmacher
341f1008f1 GT-1 - Documentation - fixup docs for new action builder 2020-01-13 14:16:35 -05:00
ghidorahrex
d66027e27a Merge remote-tracking branch
'origin/GT-3447-dragonmacher-test-timeout-override'

Fixes #1424
2020-01-13 13:25:00 -05:00
ghidravore
87839a58eb Merge remote-tracking branch 'origin/GT-3446-dragonmacher-refs-to-key-binding' 2020-01-10 18:53:49 -05:00
dragonmacher
8ebfd61348 GT-3446 - Review fixes 2020-01-10 18:52:47 -05:00
ghidravore
4cab252ff5 changs from review 2020-01-10 18:45:19 -05:00
dragonmacher
142ed19e84 GT-3446 - Added key binding to trigger the Show Xrefs dialog 2020-01-10 17:13:01 -05:00
ghidravore
7cfa80f8ac Added some convenience methods to GTree nodes. 2020-01-10 16:43:59 -05:00
dragonmacher
8cb4ee8f60 GT-3447 - Tests - timeout override property 2020-01-10 14:02:46 -05:00
ghidravore
3ce8d3fa39 GT-3445 fixed bug when invoking column filters on keybindings table 2020-01-09 14:50:31 -05:00
ghidravore
3c2c23d8ce GT-3440 fixed bug where finding words in strings wasn't handling tabs
correctly
2020-01-09 13:07:04 -05:00
Ryan Kurtz
14b1e663f0 Merge remote-tracking branch 'origin/GT-2229_adamopolous_function-comparison-fixes' 2020-01-08 09:40:22 -05:00
Ryan Kurtz
068a2f455e Merge remote-tracking branch 'origin/GT-3432-dragonmacher-drag-n-drop'
(fixes #1396)
2020-01-08 09:34:07 -05:00
dragonmacher
14ee95c395 GT-3436 - Fixed symbol tree navigation to work on already selected node 2020-01-03 17:19:27 -05:00
dragonmacher
adbbc25542 GT-3432 - Fixed recently broken drag-n-drop from the Front End to a
running Tool
2020-01-03 15:42:21 -05:00
adamopolous
a682ef31ea added domain object listener for function remove events 2020-01-03 14:55:21 -05:00
Ryan Kurtz
4fad1c9146 Merge remote-tracking branch
'origin/GT-3430-dragonmacher-call-tree-key-binding' (fixes #1227)
2019-12-31 11:08:30 -05:00
Ryan Kurtz
9d66900025 Merge remote-tracking branch
'origin/GT-3427-dragonmacher-gtree-f2-edit-key' (fixes #1356)
2019-12-31 11:07:19 -05:00
ghidravore
4dea312e59 Merge remote-tracking branch 'origin/ghidravore_action_builder' 2019-12-30 14:45:33 -05:00
ghidravore
51e0e07edb Create builders for docking actions 2019-12-30 14:42:08 -05:00
dragonmacher
74b67be5ed GT-3430 - Key Bindings - Updated the Function Call Trees Plugin's
actions key bindings so users can set the bindings separately
2019-12-30 12:02:46 -05:00
dragonmacher
1b557ee45f GT-3427 - GTree - Updated key binding code to allow for F2 ke to be used 2019-12-27 17:37:50 -05:00
Ryan Kurtz
cbe5b9e9ca Merge remote-tracking branch
'origin/GT-3411-dragonmacher-dt-keybindings' (fixes #1355)
2019-12-27 13:04:18 -05:00
dragonmacher
f1183dd4e5 GT-3411 - small review fix 2019-12-27 12:54:32 -05:00
ghidravore
bca65330a8 GT-0 fixing junit tests 2019-12-23 16:15:54 -05:00
dev747368
93bcabe582 GT-3407 Fix UnsupportedOp Exception with JISAutodetect charset. #1358
Fixes github issue #1358.


Some character sets don't support the encoding operation.
2019-12-23 16:02:15 -05:00
dev747368
4c57727282 GT-3347 tweak hex formatting of out-of-range values 2019-12-23 16:02:14 -05:00
dev747368
3faebfebe8 GT-3347 - code cleanup, code review
Unify char representation and string representation code paths.
Add CHAR_SEQ string layout enum.
Misc javadocs.
2019-12-23 16:02:13 -05:00
dev747368
603ca28c01 GT-3347 - code review tweaks
Handle bitfields formatted as char.
Change how endianness affects display of char sequences in data
elements.
2019-12-23 15:57:57 -05:00
dev747368
73155ce499 GT-3347, PR #1241 - fix convert to char sequence menu item
Finish up integrating fixes for convert to char sequence, make
everything use StringDataInstance instead of StringUtils.toQuoteString.

Fix StringRenderBuilder to use '\x' for ASCII range escape sequences
(was using 2 byte wide for ASCII escape chars).
2019-12-23 15:57:57 -05:00
Alessandro Gatti
0c97e44bf7 Don't use StringUtilties.toQuotedString. 2019-12-23 15:57:56 -05:00
Alessandro Gatti
e2354a7976 Use the proper length for string types in listing.
Character sequences were univocally rendered as a single character
regardless of their length.  This patch attempts to correct the issue,
by allowing multi-char sequences to be represented as strings if
possible.
2019-12-23 15:57:55 -05:00
dragonmacher
881dca75bf Tests - fixed tests failing to bad test mouse clicking and focus 2019-12-23 15:35:21 -05:00
dragonmacher
599728ec49 GT-3411 - Actions - fixed key bindings being removed from options after
tool restart
2019-12-23 11:09:21 -05:00
ghidra1
3ea8770bae GT-3415 Added mutability setting to enum datatypes as well as some code
cleanup.
2019-12-20 16:48:34 -05:00
Ryan Kurtz
cf4328bda4 Merge remote-tracking branch
'origin/GT-3302-dragonmacher-front-end-ui-lockup'

Conflicts:
	Ghidra/Features/Base/src/main/java/ghidra/app/plugin/core/datamgr/DataTypeManagerPlugin.java
2019-12-19 15:30:21 -05:00
Ryan Kurtz
d0538bfe6a Merge branch 'GT-3418_ryanmkurtz_PR-1361_jlacomis_typo-fix' 2019-12-19 14:37:37 -05:00
Ryan Kurtz
ccca215ef8 Merge branch 'GT-3416_ryanmkurtz_PR-1354_agatti_plugindetailhtml' 2019-12-19 14:17:27 -05:00
Jeremy Lacomis
e14d061e33 Fix "Propery" typos. 2019-12-19 13:00:59 -05:00
Ryan Kurtz
43f766e954 Merge remote-tracking branch 'origin/GT-3396-dragonmacher-file-chooser-quick-lookup' 2019-12-19 11:24:33 -05:00
Alessandro Gatti
fd3b1b28cc Use StringBuilder to build the menu path string. 2019-12-17 21:58:48 +01:00
Alessandro Gatti
0d82026555 Don't escape menupath separator in plugin details. 2019-12-17 20:56:57 +01:00