refactoring

lam/templates/tools/multiEdit.php

@@ -476,6 +476,7 @@ function dryRun(): array {
 	// store LDIF
 	$filename = 'ldif' . getRandomNumber() . '.ldif';
 	$out = @fopen(dirname(__FILE__) . '/../../tmp/' . $filename, "wb");
+	if ($out !== false) {
 		fwrite($out, $ldif);
 		$container->addElement(new htmlOutputText(_('LDIF file')), true);
 		$ldifLink = new htmlLink($filename, '../../tmp/' . $filename);
@@ -486,6 +487,7 @@ function dryRun(): array {
 		$container->addElement(new htmlInputTextarea('log', $log, 100, 30), true);
 		// generate HTML
 		fclose ($out);
+	}
 	ob_start();
 	$tabindex = 1;
 	parseHtml(null, $container, array(), true, $tabindex, 'user');
@@ -587,13 +589,16 @@ function doModify(): array {
  * Returns the HTML code for a htmlStatusMessage
  *
  * @param htmlStatusMessage $msg message
- * @return String HTML code
+ * @return string HTML code
  */
-function getMessageHTML($msg) {
+function getMessageHTML(htmlStatusMessage $msg): string {
 	$tabindex = 0;
 	ob_start();
 	parseHtml(null, $msg, array(), true, $tabindex, 'user');
 	$content = ob_get_contents();
 	ob_end_clean();
+	if ($content === false) {
+		return '';
+	}
 	return $content;
 }

lam/templates/tools/ou_edit.php

@@ -14,7 +14,7 @@ use \htmlGroup;
 /*
 
   This code is part of LDAP Account Manager (http://www.ldap-account-manager.org/)
-  Copyright (C) 2003 - 2021  Roland Gruber
+  Copyright (C) 2003 - 2022  Roland Gruber
 
   This program is free software; you can redistribute it and/or modify
   it under the terms of the GNU General Public License as published by
@@ -115,8 +115,12 @@ if (isset($_POST['createOU']) || isset($_POST['deleteOU'])) {
 	elseif (isset($_POST['deleteOU'])) {
 		// check for sub entries
 		$sr = ldap_list($_SESSION['ldap']->server(), $_POST['deleteableOU'], "ObjectClass=*", array(""));
+		if ($sr === false) {
+			$error = _("OU is not empty or invalid!");
+		}
+		else {
 			$info = ldap_get_entries($_SESSION['ldap']->server(), $sr);
-		if ($sr && ($info['count'] === 0)) {
+			if (($info !== false) && ($info['count'] === 0)) {
 				// print header
 				include '../../lib/adminHeader.inc';
 				echo '<div class="smallPaddingContent">';
@@ -150,6 +154,7 @@ if (isset($_POST['createOU']) || isset($_POST['deleteOU'])) {
 			}
 		}
 	}
+}
 
 display_main($message, $error);
 

lam/templates/tools/treeView.php

@@ -75,6 +75,7 @@ function showTree(): void {
 			if ((strlen($initialDn) > strlen($rootDn)) && substr($initialDn, -1 * strlen($rootDn)) === $rootDn) {
 				$extraDnPart = substr($initialDn, 0, (-1 * strlen($rootDn)) - 1);
 				$dnParts = ldap_explode_dn($extraDnPart, 0);
+				if ($dnParts !== false) {
 					unset($dnParts['count']);
 					$dnPartsCount = sizeof($dnParts);
 					for ($i = 0; $i < $dnPartsCount; $i++) {
@@ -84,6 +85,7 @@ function showTree(): void {
 				}
 			}
 		}
+	}
 	$openInitialJsArray = '[' . implode(', ', $openInitial) . ']';
 	$row = new htmlResponsiveRow();
 	$row->setCSSClasses(array('maxrow'));

lam/templates/upload/massBuildAccounts.php

@@ -126,6 +126,7 @@ if ($_FILES['inputfile'] && ($_FILES['inputfile']['size'] > 0)) {
 	$uploadColumns = getUploadColumns($type, $selectedModules);
 	// read input file
 	$handle = fopen ($_FILES['inputfile']['tmp_name'], "r");
+	if ($handle !== false) {
 		if (($head = fgetcsv($handle, 2000)) !== false ) { // head row
 			foreach ($head as $i => $headItem) {
 				$ids[$headItem] = $i;
@@ -134,6 +135,8 @@ if ($_FILES['inputfile'] && ($_FILES['inputfile']['size'] > 0)) {
 		while (($line = fgetcsv($handle, 2000)) !== false ) { // account rows
 			$data[] = $line;
 		}
+		fclose($handle);
+	}
 
 	$errors = array();
 

phpstan.neon

@@ -28,3 +28,6 @@ parameters:
 		- '#Cannot assign new offset to array<int, string>\|string.#'
 		- '#Parameter \#1 \$result of function ldap_free_result expects LDAP\\Result, array\|LDAP\\Result given.#'
 		- '#Cannot access offset .* on array\|int.#'
+		- '#Parameter \#1 \$haystack of function strpos expects string, int\|string given.#'
+		- '#Argument of an invalid type array\|int supplied for foreach, only iterables are supported.#'
+		- '#Cannot access offset mixed on non-empty-array\|int.#'