From 38b9e3d7a87d92c13e6519647d0b10dc677bc579 Mon Sep 17 00:00:00 2001
From: Roland Gruber <post@rolandgruber.de>
Date: Mon, 16 Jan 2023 19:46:17 +0100
Subject: [PATCH] refactoring

---
 lam/templates/lib/500_lam.js | 20 ++++++++++----------
 lam/templates/misc/ajax.php  |  4 ++--
 phpstan.neon                 |  1 +
 3 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/lam/templates/lib/500_lam.js b/lam/templates/lib/500_lam.js
index 5be1f34f8..5a2c2223e 100644
--- a/lam/templates/lib/500_lam.js
+++ b/lam/templates/lib/500_lam.js
@@ -458,20 +458,20 @@ function checkPasswordStrength(fieldID, ajaxURL, tokenName, tokenValue) {
  * @param fieldID input field ID
  */
 function checkPasswordStrengthHandleReply(data, fieldID) {
-	var field = jQuery('#' + fieldID);
+	const field = document.getElementById(fieldID);
 	if (data.result === true) {
-		field.removeClass('markFail');
-		field.addClass('markOk');
-		field.prop('title', '');
+		field.classList.remove('markFail');
+		field.classList.add('markOk');
+		field.title = '';
 	}
-	else if (field.val() == '') {
-		field.removeClass('markFail');
-		field.removeClass('markOk');
+	else if (field.value == '') {
+		field.classList.remove('markFail');
+		field.classList.remove('markOk');
 	}
 	else {
-		field.addClass('markFail');
-		field.removeClass('markOk');
-		field.prop('title', data.result);
+		field.classList.add('markFail');
+		field.classList.remove('markOk');
+		field.title = data.result;
 	}
 }
 
diff --git a/lam/templates/misc/ajax.php b/lam/templates/misc/ajax.php
index 2d72d96d1..2a6b981b9 100644
--- a/lam/templates/misc/ajax.php
+++ b/lam/templates/misc/ajax.php
@@ -192,7 +192,7 @@ class Ajax {
 	 *
 	 * @param array<mixed> $input input parameters
 	 */
-	private static function managePasswordChange($input): void {
+	private static function managePasswordChange(array $input): void {
 		$sessionKey  = htmlspecialchars($_GET['editKey']);
 		$return = $_SESSION[$sessionKey]->setNewPassword($input);
 		echo json_encode($return);
@@ -203,7 +203,7 @@ class Ajax {
 	 *
 	 * @param array<mixed> $input input parameters
 	 */
-	private function checkPasswordStrength($input): void {
+	private function checkPasswordStrength(array $input): void {
 		$password = $input['password'];
 		$result = checkPasswordStrength($password, null, null);
 		echo json_encode(array("result" => $result));
diff --git a/phpstan.neon b/phpstan.neon
index 26a18957f..07b8682ce 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -35,3 +35,4 @@ parameters:
 		- '#Argument of an invalid type mixed supplied for foreach, only iterables are supported.#'
 		- '#Parameter \#2 \$args of function call_user_func_array expects array<int\|string, mixed>, mixed given.#'
 		- '#Parameter \#1 \$input of method LAM\\AJAX\\Ajax::managePasswordChange\(\) expects array, mixed given.#'
+		- '#Parameter \#1 \$input of method LAM\\AJAX\\Ajax::checkPasswordStrength\(\) expects array, mixed given.#'