From 64b2caf28ea13c2a2fe588f8dc183909246d6269 Mon Sep 17 00:00:00 2001 From: Roland Gruber Date: Wed, 20 Apr 2022 19:11:15 +0200 Subject: [PATCH] refactoring --- .github/workflows/php.yml | 9 ++++++--- codespell.sh | 3 +++ lam/codespell.sh | 3 --- lam/tests/design/designExamples.php | 4 ++-- 4 files changed, 11 insertions(+), 8 deletions(-) create mode 100755 codespell.sh delete mode 100755 lam/codespell.sh diff --git a/.github/workflows/php.yml b/.github/workflows/php.yml index e1d75a1ab..fcac20183 100644 --- a/.github/workflows/php.yml +++ b/.github/workflows/php.yml @@ -29,12 +29,15 @@ jobs: - name: Install dependencies run: composer install --prefer-dist --no-progress - # Add a test script to composer.json, for instance: "test": "vendor/bin/phpunit" - # Docs: https://getcomposer.org/doc/articles/scripts.md - - name: Run test suite run: composer run-script test + - name: Install CodeSpell + run: pip install --user codespell + + - name: CodeSpell + run: ./codespell + - name: SonarCloud Scan uses: sonarsource/sonarcloud-github-action@master env: diff --git a/codespell.sh b/codespell.sh new file mode 100755 index 000000000..3edc1dbfe --- /dev/null +++ b/codespell.sh @@ -0,0 +1,3 @@ +#!/bin/bash + +~/.local/bin/codespell --skip '*3rdParty*,*/ckeditor/*,*/po/*,*/locale/*,tmp,sess,config,graphics,*/style/images/*,*/style/*.gif,*/style/*.png,*/docs/manual-onePage/*,*/docs/manual-sources/images/*,*/templates/lib/*jquery*,*/templates/lib/*flatpickr*,*~,*/docs/phpdoc/*,*/docs/manual/*,*/docs/devel/images/*,*/docs/manual-pdf/*,*.sh,*/cropper.js,*/lib/extra/*,lam/.phpdoc' --ignore-words-list "tim,te,pres,files'" lam diff --git a/lam/codespell.sh b/lam/codespell.sh deleted file mode 100755 index 84cfc8a46..000000000 --- a/lam/codespell.sh +++ /dev/null @@ -1,3 +0,0 @@ -#!/bin/bash - -~/.local/bin/codespell --skip '*3rdParty*,*/ckeditor/*,*/po/*,*/locale/*,tmp,sess,config,graphics,*/style/images/*,*/style/*.gif,*/style/*.png,*/docs/manual-onePage/*,*/docs/manual-sources/images/*,*/templates/lib/*jquery*,*~,*/docs/phpdoc/*,*/docs/manual/*,*/docs/devel/images/*,*/docs/manual-pdf/*,*.sh,*/cropper.js,*/lib/extra/*' --ignore-words-list "tim,te,pres,files'" diff --git a/lam/tests/design/designExamples.php b/lam/tests/design/designExamples.php index 761ca0890..41382d36f 100644 --- a/lam/tests/design/designExamples.php +++ b/lam/tests/design/designExamples.php @@ -73,8 +73,8 @@ $tableTitles = array('text 1', 'text 2', 'text 3', 'text 4', 'text 5'); $tableData = array(); for ($rowNumber = 0; $rowNumber < 10; $rowNumber++) { $tableRow = array(); - for ($colum = 0; $colum < 5; $colum++) { - $tableRow[] = new htmlOutputText('value' . $colum); + for ($column = 0; $column < 5; $column++) { + $tableRow[] = new htmlOutputText('value' . $column); } $tableData[] = $tableRow; }