From dd3330a41b63b016cbbfe1dae5ca61160869d268 Mon Sep 17 00:00:00 2001
From: Roland Gruber <post@rolandgruber.de>
Date: Thu, 2 Oct 2025 21:55:55 +0200
Subject: [PATCH] refactoring

---
 lam/lib/import.inc | 8 ++++----
 phpstan.neon       | 1 -
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/lam/lib/import.inc b/lam/lib/import.inc
index 6e280fcbb..db4ffdcea 100644
--- a/lam/lib/import.inc
+++ b/lam/lib/import.inc
@@ -444,7 +444,7 @@ class AddEntryTask implements ImporterTask {
 	 * Constructor
 	 *
 	 * @param string $dn DN
-	 * @param array[string[]] $attributes list of attributes
+	 * @param array<string, string[]> $attributes list of attributes
 	 */
 	public function __construct($dn, $attributes) {
 		$this->dn = $dn;
@@ -601,7 +601,7 @@ class AddAttributesTask implements ImporterTask {
 	 * Constructor
 	 *
 	 * @param string $dn DN
-	 * @param array[string[]] $attributes list of attributes
+	 * @param array<string, string[]> $attributes list of attributes
 	 */
 	public function __construct($dn, $attributes) {
 		$this->dn = $dn;
@@ -657,7 +657,7 @@ class DeleteAttributesTask implements ImporterTask {
 	 *
 	 * @param string $dn DN
 	 * @param string $attributeName attribute name
-	 * @param array[string[]] $attributes list of attributes
+	 * @param array<string, string[]> $attributes list of attributes
 	 */
 	public function __construct($dn, $attributeName, $attributes) {
 		$this->dn = $dn;
@@ -726,7 +726,7 @@ class ReplaceAttributesTask implements ImporterTask {
 	 * Constructor
 	 *
 	 * @param string $dn DN
-	 * @param array[string[]] $attributes list of attributes
+	 * @param array<string, string[]> $attributes list of attributes
 	 */
 	public function __construct($dn, $attributes) {
 		$this->dn = $dn;
diff --git a/phpstan.neon b/phpstan.neon
index 5b1fcb6d8..b920f9bfe 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -44,7 +44,6 @@ parameters:
 			- lam/lib/plugins/extendedInvalidCredentials/MitKerberosExtraInvalidCredentialsProvider.inc (?)
 	ignoreErrors:
 		- '#Variable \$helpArray might not be defined.#'
-		- '#Offset .SID. on array.*in isset\(\) always exists.*#'
 		- '#Offset .preferred_username. does not exist on.*#'
 		- '#Strict comparison using !== between non-empty-list.*will always evaluate to true.*#'
 		- '#Strict comparison using !== between non-empty-array.*will always evaluate to true.*#'