yetangitu/librespot
1
0
Fork 0
mirror of https://github.com/librespot-org/librespot.git synced 2025-10-03 09:49:31 +02:00
Code Issues Releases Wiki Activity

removes homething devicetype (#1471)

Browse source 
* removes homething devicetype

fixes #1470

From the comments about "homething" support in spotify:
"Did they ever release their homething product? I assumed not and guess they removed all support for it. We could just remove this footgun."

* mention breaking homething change in Changelog
This commit is contained in:
Christoph 2025-03-03 15:06:48 +01:00 • committed by GitHub
parent 09b4aa41e5
commit 11c3df8eb1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.md
View file

@ -49,6 +49,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Removed ### Removed
- [core] Removed `get_canvases` from SpClient (breaking) - [core] Removed `get_canvases` from SpClient (breaking)
- [core] DeviceType `homething` removed due to crashes on Android (breaking)
- [metadata] Removed `genres` from Album (breaking) - [metadata] Removed `genres` from Album (breaking)
- [metadata] Removed `genre` from Artists (breaking) - [metadata] Removed `genre` from Artists (breaking)

4
core/src/config.rs
View file

@ -79,7 +79,6 @@ pub enum DeviceType {
UnknownSpotify = 100, UnknownSpotify = 100,
CarThing = 101, CarThing = 101,
Observer = 102, Observer = 102,
HomeThing = 103,
} }
impl FromStr for DeviceType { impl FromStr for DeviceType {
@ -102,7 +101,6 @@ impl FromStr for DeviceType {
"smartwatch" => Ok(Smartwatch), "smartwatch" => Ok(Smartwatch),
"chromebook" => Ok(Chromebook), "chromebook" => Ok(Chromebook),
"carthing" => Ok(CarThing), "carthing" => Ok(CarThing),
"homething" => Ok(HomeThing),
_ => Err(()), _ => Err(()),
} }
} }
@ -130,7 +128,6 @@ impl From<&DeviceType> for &str {
UnknownSpotify => "UnknownSpotify", UnknownSpotify => "UnknownSpotify",
CarThing => "CarThing", CarThing => "CarThing",
Observer => "Observer", Observer => "Observer",
HomeThing => "HomeThing",
} }
} }
} }
@ -169,7 +166,6 @@ impl From<DeviceType> for ProtoDeviceType {
DeviceType::UnknownSpotify => ProtoDeviceType::UNKNOWN_SPOTIFY, DeviceType::UnknownSpotify => ProtoDeviceType::UNKNOWN_SPOTIFY,
DeviceType::CarThing => ProtoDeviceType::CAR_THING, DeviceType::CarThing => ProtoDeviceType::CAR_THING,
DeviceType::Observer => ProtoDeviceType::OBSERVER, DeviceType::Observer => ProtoDeviceType::OBSERVER,
DeviceType::HomeThing => ProtoDeviceType::HOME_THING,
} }
} }
} }

2
src/main.rs
View file

@ -1471,7 +1471,7 @@ fn get_setup() -> Setup {
speaker, tv, avr, stb, audiodongle, \ speaker, tv, avr, stb, audiodongle, \
gameconsole, castaudio, castvideo, \ gameconsole, castaudio, castvideo, \
automobile, smartwatch, chromebook, \ automobile, smartwatch, chromebook, \
carthing, homething", carthing",
DeviceType::default().into(), DeviceType::default().into(),
); );