yetangitu/photo-python
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Delete methods should raise exception on failure, rather than returning False

Browse source
This commit is contained in:
sneakypete81 2013-06-30 17:34:41 +01:00
parent 3f1757d0aa
commit 9968d7f265
4 changed files with 8 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/unit/test_photos.py
View file

@ -112,8 +112,6 @@ class TestPhotoDelete(TestPhotos):
mock_post.assert_called_with("/photo/1a/delete.json")
self.assertEqual(result, True)
# TODO: photo.delete should raise exception on failure
@unittest.expectedFailure
@mock.patch.object(openphoto.OpenPhoto, 'post')
def test_photo_delete_failure(self, mock_post):
"""Check that an exception is raised if a photo cannot be deleted"""
@ -136,8 +134,6 @@ class TestPhotoDelete(TestPhotos):
self.assertEqual(photo.get_fields(), {})
# self.assertEqual(photo.id, None)
# TODO: photo.delete should raise exception on failure
@unittest.expectedFailure
@mock.patch.object(openphoto.OpenPhoto, 'post')
def test_photo_object_delete_failure(self, mock_post):
"""