From a97851b82ab2e0973033168967a44335d534d8e2 Mon Sep 17 00:00:00 2001 From: Pete Date: Mon, 26 Aug 2013 12:46:20 -0700 Subject: [PATCH] Add tests for invalid return types --- tests/unit/test_actions.py | 8 ++++++++ tests/unit/test_activities.py | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/tests/unit/test_actions.py b/tests/unit/test_actions.py index 6dd7ece..3028dbf 100644 --- a/tests/unit/test_actions.py +++ b/tests/unit/test_actions.py @@ -63,6 +63,14 @@ class TestActionCreate(TestActions): with self.assertRaises(NotImplementedError): self.client.action.create(target=object(), foo="bar") + @mock.patch.object(trovebox.Trovebox, 'post') + def test_action_create_invalid_return_type(self, mock_post): + """Check that an exception is raised if an non photo object is returned""" + mock_post.return_value = self._return_value({"target": "test", + "target_type": "invalid"}) + with self.assertRaises(NotImplementedError): + self.client.action.create(target=self.test_photos[0], foo="bar") + class TestActionDelete(TestActions): @mock.patch.object(trovebox.Trovebox, 'post') def test_action_delete(self, mock_post): diff --git a/tests/unit/test_activities.py b/tests/unit/test_activities.py index 976197b..0ea190f 100644 --- a/tests/unit/test_activities.py +++ b/tests/unit/test_activities.py @@ -117,3 +117,11 @@ class TestActivityView(TestActivities): activity.view(foo="bar") mock_get.assert_called_with("/activity/1/view.json", foo="bar") self.assertEqual(activity.get_fields(), self.test_activities_dict[1]) + + @mock.patch.object(trovebox.Trovebox, 'get') + def test_activity_view_invalid_type(self, mock_get): + """Check that an invalid activity type raises an exception""" + mock_get.return_value = self._return_value(self._view_wrapper( + {"data": "", "type": "invalid"})) + with self.assertRaises(NotImplementedError): + self.client.activity.view(self.test_activities[0], foo="bar")