yetangitu/photo-python
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Not that frontend issue 955 is resolved, we should use the return value of the transform API to replace the photo object's fields

Browse source
This commit is contained in:
sneakypete81 2013-04-13 13:11:26 +01:00
parent ee3840de9f
commit ea904e4337
3 changed files with 3 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
openphoto/api_photo.py
View file

@ -111,6 +111,4 @@ class ApiPhoto:
if not isinstance(photo, Photo): if not isinstance(photo, Photo):
photo = Photo(self._client, {"id": photo}) photo = Photo(self._client, {"id": photo})
photo.transform(**kwds) photo.transform(**kwds)
# The API doesn't currently return the transformed photo return photo
# Uncomment the below once frontend issue #955 is resolved
# return photo

6
openphoto/objects.py
View file

@ -98,14 +98,12 @@ class Photo(OpenPhotoObject):
def transform(self, **kwds): def transform(self, **kwds):
""" """
Performs transformation specified in **kwds Performs transformation specified in **kwds
Example: transform(rotate=90) Example: transform(rotate=90)
""" """
new_dict = self._openphoto.post("/photo/%s/transform.json" % self.id, new_dict = self._openphoto.post("/photo/%s/transform.json" % self.id,
**kwds)["result"] **kwds)["result"]
# The API doesn't currently return the transformed photo self._replace_fields(new_dict)
# Uncomment the below once frontend issue #955 is resolved
# self._replace_fields(new_dict)
class Tag(OpenPhotoObject): class Tag(OpenPhotoObject):
def delete(self, **kwds): def delete(self, **kwds):

10
tests/test_photos.py
View file

@ -151,18 +151,8 @@ class TestPhotos(test_base.TestBase):
photo = self.photos[0] photo = self.photos[0]
self.assertEqual(photo.rotation, "0") self.assertEqual(photo.rotation, "0")
photo = self.client.photo.transform(photo, rotate=90) photo = self.client.photo.transform(photo, rotate=90)
# Need an explicit update, since transform API doesn't return the rotated photo
# Remove the following line once Issue #955 is resolved
photo = self.client.photo.view(self.photos[0])
self.assertEqual(photo.rotation, "90") self.assertEqual(photo.rotation, "90")
# Do the same using the Photo object directly # Do the same using the Photo object directly
photo.transform(rotate=90) photo.transform(rotate=90)
# Need an explicit update, since transform API doesn't return the rotated photo
# Remove the following line once Issue #955 is resolved
photo = self.client.photo.view(photo)
self.assertEqual(photo.rotation, "180") self.assertEqual(photo.rotation, "180")