yetangitu/photo-python
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Remove photo dynamic_url, since this is marked as "internal" in the frontend code

Browse source
This commit is contained in:
sneakypete81 2013-09-15 11:28:40 +01:00
parent 3a13d13c42
commit ebaf3bc036
4 changed files with 0 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tests/functional/test_photos.py
View file

@ -202,11 +202,6 @@ class TestPhotos(test_base.TestBase):
allowDuplicate=True) allowDuplicate=True)
self.assertEqual(self.photos[0].hash, original_hash) self.assertEqual(self.photos[0].hash, original_hash)
def test_dynamic_url(self):
""" If photo.dynamic_url gets implemented, write a test! """
with self.assertRaises(NotImplementedError):
self.client.photo.dynamic_url(None)
def test_transform(self): def test_transform(self):
""" Test photo rotation """ """ Test photo rotation """
photo = self.photos[0] photo = self.photos[0]

19
tests/unit/test_photos.py
View file

@ -446,25 +446,6 @@ class TestPhotoUploadFromUrl(TestPhotos):
photo="test_url", title="Test") photo="test_url", title="Test")
self.assertEqual(result.get_fields(), self.test_photos_dict[0]) self.assertEqual(result.get_fields(), self.test_photos_dict[0])
class TestPhotoDynamicUrl(TestPhotos):
@mock.patch.object(trovebox.Trovebox, 'get')
def test_photo_dynamic_url(self, _):
""" If photo.dynamic_url gets implemented, write a test! """
with self.assertRaises(NotImplementedError):
self.client.photo.dynamic_url(self.test_photos[0])
@mock.patch.object(trovebox.Trovebox, 'get')
def test_photo_dynamic_url_id(self, _):
""" If photo.dynamic_url gets implemented, write a test! """
with self.assertRaises(NotImplementedError):
self.client.photo.dynamic_url("1a")
@mock.patch.object(trovebox.Trovebox, 'get')
def test_photo_object_dynamic_url(self, _):
""" If photo.dynamic_url gets implemented, write a test! """
with self.assertRaises(NotImplementedError):
self.test_photos[0].dynamic_url()
class TestPhotoNextPrevious(TestPhotos): class TestPhotoNextPrevious(TestPhotos):
@mock.patch.object(trovebox.Trovebox, 'get') @mock.patch.object(trovebox.Trovebox, 'get')
def test_photo_next_previous(self, mock_get): def test_photo_next_previous(self, mock_get):

5
trovebox/api/api_photo.py
View file

@ -187,11 +187,6 @@ class ApiPhoto(ApiBase):
**kwds)["result"] **kwds)["result"]
return Photo(self._client, result) return Photo(self._client, result)
def dynamic_url(self, photo, **kwds):
""" Not yet implemented """
raise NotImplementedError()
# TODO: Add options
def next_previous(self, photo, options=None, **kwds): def next_previous(self, photo, options=None, **kwds):
""" """
Endpoint: /photo/<id>/nextprevious[/<options>].json Endpoint: /photo/<id>/nextprevious[/<options>].json

4
trovebox/objects/photo.py
View file

@ -81,10 +81,6 @@ class Photo(TroveboxObject):
result = self._client.photo.view(self, options, **kwds) result = self._client.photo.view(self, options, **kwds)
self._replace_fields(result.get_fields()) self._replace_fields(result.get_fields())
def dynamic_url(self, **kwds):
""" Not implemented yet """
raise NotImplementedError()
def next_previous(self, options=None, **kwds): def next_previous(self, options=None, **kwds):
""" """
Endpoint: /photo/<id>/nextprevious[/<options>].json Endpoint: /photo/<id>/nextprevious[/<options>].json