yetangitu/recoll
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

comment

Browse source
This commit is contained in:
Jean-Francois Dockes 2012-06-05 14:14:02 +02:00
parent 6cc820d1eb
commit e909fc21e8
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/internfile/mimehandler.h
View file

@ -57,9 +57,14 @@ public:
// We don't use this for now // We don't use this for now
virtual bool set_document_uri(const std::string &) {return false;} virtual bool set_document_uri(const std::string &) {return false;}
/// This does nothing right now but should be called from the // This does nothing right now but should be called from the
/// subclass method in case we need some common processing one day // subclass method in case we need some common processing one day
/// (was used for xattrs at some point). // (was used for xattrs at some point). Yes this is the "call
// super" anti-pattern, bad, but we have several layers of derived
// classes, so that implementing the template method approach (by
// having a pure virtual called from here and implemented in the
// subclass) would have to be repeated in each derived class. It's
// just simpler this way.
virtual bool set_document_file(const string & /*file_path*/) {return true;} virtual bool set_document_file(const string & /*file_path*/) {return true;}
// Default implementations // Default implementations
@ -94,6 +99,8 @@ public:
return m_reason; return m_reason;
} }
// "Call super" anti-pattern again. Must be called from derived
// classes which reimplement clear()
virtual void clear() { virtual void clear() {
Dijon::Filter::clear(); Dijon::Filter::clear();
m_forPreview = m_havedoc = false; m_forPreview = m_havedoc = false;