refactor: add readonly to many read only fields

libraries/adb-credential-web/src/index.ts

@@ -68,7 +68,7 @@ async function getAllKeys() {
  * and stores them in IndexedDB.
  */
 export default class AdbWebCredentialStore implements AdbCredentialStore {
-    #appName: string;
+    readonly #appName: string;
 
     constructor(appName = "Tango") {
         this.#appName = appName;

libraries/adb-daemon-webusb/src/device.ts

@@ -54,27 +54,27 @@ export function mergeDefaultAdbInterfaceFilter(
 export class AdbDaemonWebUsbConnection
     implements ReadableWritablePair<AdbPacketData, Consumable<AdbPacketInit>>
 {
-    #device: AdbDaemonWebUsbDevice;
+    readonly #device: AdbDaemonWebUsbDevice;
     get device() {
         return this.#device;
     }
 
-    #inEndpoint: USBEndpoint;
+    readonly #inEndpoint: USBEndpoint;
     get inEndpoint() {
         return this.#inEndpoint;
     }
 
-    #outEndpoint: USBEndpoint;
+    readonly #outEndpoint: USBEndpoint;
     get outEndpoint() {
         return this.#outEndpoint;
     }
 
-    #readable: ReadableStream<AdbPacketData>;
+    readonly #readable: ReadableStream<AdbPacketData>;
     get readable() {
         return this.#readable;
     }
 
-    #writable: WritableStream<Consumable<AdbPacketInit>>;
+    readonly #writable: WritableStream<Consumable<AdbPacketInit>>;
     get writable() {
         return this.#writable;
     }
@@ -233,15 +233,15 @@ export class AdbDaemonWebUsbConnection
 export class AdbDaemonWebUsbDevice implements AdbDaemonDevice {
     static DeviceBusyError = _DeviceBusyError;
 
-    #interface: UsbInterfaceIdentifier;
-    #usbManager: USB;
+    readonly #interface: UsbInterfaceIdentifier;
+    readonly #usbManager: USB;
 
-    #raw: USBDevice;
+    readonly #raw: USBDevice;
     get raw() {
         return this.#raw;
     }
 
-    #serial: string;
+    readonly #serial: string;
     get serial(): string {
         return this.#serial;
     }

libraries/adb-daemon-webusb/src/manager.ts

@@ -23,7 +23,7 @@ export class AdbDaemonWebUsbDeviceManager {
             ? new AdbDaemonWebUsbDeviceManager(globalThis.navigator.usb)
             : undefined)();
 
-    #usbManager: USB;
+    readonly #usbManager: USB;
 
     /**
      * Create a new instance of {@link AdbDaemonWebUsbDeviceManager} using the specified WebUSB implementation.

libraries/adb/src/adb.ts

@@ -9,10 +9,10 @@ import type { AdbBanner } from "./banner.js";
 import type { AdbFrameBuffer } from "./commands/index.js";
 import {
     AdbPower,
-    AdbReverseCommand,
+    AdbReverseService,
     AdbSubprocessService,
     AdbSync,
-    AdbTcpIpCommand,
+    AdbTcpIpService,
     escapeArg,
     framebuffer,
 } from "./commands/index.js";
@@ -61,26 +61,29 @@ export interface AdbTransport extends Closeable {
 }
 
 export class Adb implements Closeable {
-    readonly transport: AdbTransport;
+    readonly #transport: AdbTransport;
+    get transport(): AdbTransport {
+        return this.#transport;
+    }
 
     get serial() {
-        return this.transport.serial;
+        return this.#transport.serial;
     }
 
     get maxPayloadSize() {
-        return this.transport.maxPayloadSize;
+        return this.#transport.maxPayloadSize;
     }
 
     get banner() {
-        return this.transport.banner;
+        return this.#transport.banner;
     }
 
     get disconnected() {
-        return this.transport.disconnected;
+        return this.#transport.disconnected;
     }
 
     public get clientFeatures() {
-        return this.transport.clientFeatures;
+        return this.#transport.clientFeatures;
     }
 
     public get deviceFeatures() {
@@ -89,16 +92,16 @@ export class Adb implements Closeable {
 
     readonly subprocess: AdbSubprocessService;
     readonly power: AdbPower;
-    readonly reverse: AdbReverseCommand;
-    readonly tcpip: AdbTcpIpCommand;
+    readonly reverse: AdbReverseService;
+    readonly tcpip: AdbTcpIpService;
 
     constructor(transport: AdbTransport) {
-        this.transport = transport;
+        this.#transport = transport;
 
         this.subprocess = new AdbSubprocessService(this);
         this.power = new AdbPower(this);
-        this.reverse = new AdbReverseCommand(this);
-        this.tcpip = new AdbTcpIpCommand(this);
+        this.reverse = new AdbReverseService(this);
+        this.tcpip = new AdbTcpIpService(this);
     }
 
     canUseFeature(feature: AdbFeature): boolean {
@@ -112,7 +115,7 @@ export class Adb implements Closeable {
      * Creates a new ADB Socket to the specified service or socket address.
      */
     async createSocket(service: string): Promise<AdbSocket> {
-        return this.transport.connect(service);
+        return this.#transport.connect(service);
     }
 
     async createSocketAndWait(service: string): Promise<string> {
@@ -162,6 +165,6 @@ export class Adb implements Closeable {
     }
 
     async close(): Promise<void> {
-        await this.transport.close();
+        await this.#transport.close();
     }
 }

libraries/adb/src/banner.ts

@@ -51,22 +51,22 @@ export class AdbBanner {
         return new AdbBanner(product, model, device, features);
     }
 
-    #product: string | undefined;
+    readonly #product: string | undefined;
     get product() {
         return this.#product;
     }
 
-    #model: string | undefined;
+    readonly #model: string | undefined;
     get model() {
         return this.#model;
     }
 
-    #device: string | undefined;
+    readonly #device: string | undefined;
     get device() {
         return this.#device;
     }
 
-    #features: AdbFeature[] = [];
+    readonly #features: AdbFeature[] = [];
     get features() {
         return this.#features;
     }

libraries/adb/src/commands/base.ts

@@ -3,7 +3,7 @@ import { AutoDisposable } from "@yume-chan/event";
 import type { Adb } from "../adb.js";
 
 export class AdbServiceBase extends AutoDisposable {
-    #adb: Adb;
+    readonly #adb: Adb;
     get adb() {
         return this.#adb;
     }

libraries/adb/src/commands/reverse.ts

@@ -9,9 +9,11 @@ import {
     struct,
 } from "@yume-chan/struct";
 
-import type { Adb, AdbIncomingSocketHandler } from "../adb.js";
+import type { AdbIncomingSocketHandler } from "../adb.js";
 import { hexToNumber, sequenceEqual } from "../utils/index.js";
 
+import { AdbServiceBase } from "./base.js";
+
 export interface AdbForwardListener {
     deviceSerial: string;
 
@@ -82,15 +84,9 @@ function decimalToNumber(buffer: Uint8Array) {
 
 const OKAY = encodeUtf8("OKAY");
 
-export class AdbReverseCommand {
-    protected adb: Adb;
-
+export class AdbReverseService extends AdbServiceBase {
     readonly #deviceAddressToLocalAddress = new Map<string, string>();
 
-    constructor(adb: Adb) {
-        this.adb = adb;
-    }
-
     protected async createBufferedStream(service: string) {
         const socket = await this.adb.createSocket(service);
         return new BufferedReadableStream(socket.readable);

libraries/adb/src/commands/subprocess/service.ts

@@ -5,17 +5,17 @@ import { AdbNoneProtocolSubprocessService } from "./none/index.js";
 import { AdbShellProtocolSubprocessService } from "./shell/index.js";
 
 export class AdbSubprocessService {
-    #adb: Adb;
+    readonly #adb: Adb;
     get adb() {
         return this.#adb;
     }
 
-    #noneProtocol: AdbNoneProtocolSubprocessService;
+    readonly #noneProtocol: AdbNoneProtocolSubprocessService;
     get noneProtocol(): AdbNoneProtocolSubprocessService {
         return this.#noneProtocol;
     }
 
-    #shellProtocol?: AdbShellProtocolSubprocessService;
+    readonly #shellProtocol?: AdbShellProtocolSubprocessService;
     get shellProtocol(): AdbShellProtocolSubprocessService | undefined {
         return this.#shellProtocol;
     }

libraries/adb/src/commands/sync/pull.ts

@@ -1,5 +1,4 @@
-import type { ReadableStream } from "@yume-chan/stream-extra";
-import { PushReadableStream } from "@yume-chan/stream-extra";
+import { ReadableStream } from "@yume-chan/stream-extra";
 import type { StructValue } from "@yume-chan/struct";
 import { buffer, struct, u32 } from "@yume-chan/struct";
 
@@ -52,10 +51,5 @@ export function adbSyncPull(
     socket: AdbSyncSocket,
     path: string,
 ): ReadableStream<Uint8Array> {
-    // TODO: use `ReadableStream.from` when it's supported
-    return new PushReadableStream(async (controller) => {
-        for await (const data of adbSyncPullGenerator(socket, path)) {
-            await controller.enqueue(data);
-        }
-    });
+    return ReadableStream.from(adbSyncPullGenerator(socket, path));
 }

libraries/adb/src/commands/sync/response.ts

@@ -2,6 +2,8 @@ import { getUint32LittleEndian } from "@yume-chan/no-data-view";
 import type { AsyncExactReadable, StructDeserializer } from "@yume-chan/struct";
 import { decodeUtf8, string, struct, u32 } from "@yume-chan/struct";
 
+import { unreachable } from "../../utils/no-op.js";
+
 function encodeAsciiUnchecked(value: string): Uint8Array {
     const result = new Uint8Array(value.length);
     for (let i = 0; i < value.length; i += 1) {
@@ -83,7 +85,7 @@ export async function* adbSyncReadResponses<T>(
         switch (getUint32LittleEndian(buffer, 0)) {
             case AdbSyncResponseId.Fail:
                 await AdbSyncFailResponse.deserialize(stream);
-                throw new Error("Unreachable");
+                unreachable();
             case AdbSyncResponseId.Done:
                 // `DONE` responses' size are always same as the request's normal response.
                 //

libraries/adb/src/commands/tcpip.ts

@@ -27,7 +27,7 @@ function parsePort(value: string): number | undefined {
     return Number.parseInt(value, 10);
 }
 
-export class AdbTcpIpCommand extends AdbServiceBase {
+export class AdbTcpIpService extends AdbServiceBase {
     async getListenAddresses(): Promise<AdbTcpIpListenAddresses> {
         const serviceListenAddresses = await this.adb.getProp(
             "service.adb.listen_addrs",

libraries/adb/src/daemon/dispatcher.ts

@@ -101,18 +101,21 @@ export class AdbPacketDispatcher implements Closeable {
      */
     readonly #sockets = new Map<number, AdbDaemonSocketController>();
 
-    #writer: WritableStreamDefaultWriter<Consumable<AdbPacketInit>>;
+    readonly #writer: WritableStreamDefaultWriter<Consumable<AdbPacketInit>>;
 
     readonly options: AdbPacketDispatcherOptions;
 
     #closed = false;
-    #disconnected = new PromiseResolver<void>();
+    readonly #disconnected = new PromiseResolver<void>();
     get disconnected() {
         return this.#disconnected.promise;
     }
 
-    #incomingSocketHandlers = new Map<string, AdbIncomingSocketHandler>();
-    #readAbortController = new AbortController();
+    readonly #incomingSocketHandlers = new Map<
+        string,
+        AdbIncomingSocketHandler
+    >();
+    readonly #readAbortController = new AbortController();
 
     constructor(
         connection: ReadableWritablePair<

libraries/adb/src/daemon/socket.ts

@@ -43,7 +43,7 @@ export class AdbDaemonSocketController
     readonly localCreated!: boolean;
     readonly service!: string;
 
-    #readable: ReadableStream<Uint8Array>;
+    readonly #readable: ReadableStream<Uint8Array>;
     #readableController!: PushReadableStreamController<Uint8Array>;
     get readable() {
         return this.#readable;
@@ -54,12 +54,12 @@ export class AdbDaemonSocketController
 
     #closed = false;
 
-    #closedPromise = new PromiseResolver<undefined>();
+    readonly #closedPromise = new PromiseResolver<undefined>();
     get closed() {
         return this.#closedPromise.promise;
     }
 
-    #socket: AdbDaemonSocket;
+    readonly #socket: AdbDaemonSocket;
     get socket() {
         return this.#socket;
     }
@@ -178,7 +178,7 @@ export class AdbDaemonSocketController
  * A duplex stream representing a socket to ADB daemon.
  */
 export class AdbDaemonSocket implements AdbDaemonSocketInfo, AdbSocket {
-    #controller: AdbDaemonSocketController;
+    readonly #controller: AdbDaemonSocketController;
 
     get localId(): number {
         return this.#controller.localId;

libraries/adb/src/server/client.ts

@@ -112,7 +112,7 @@ export class AdbServerClient {
 
     readonly wireless = new WirelessCommands(this);
     readonly mDns = new MDnsCommands(this);
-    #observerOwner = new AdbServerDeviceObserverOwner(this);
+    readonly #observerOwner = new AdbServerDeviceObserverOwner(this);
 
     constructor(connector: AdbServerClient.ServerConnector) {
         this.connector = connector;

libraries/adb/src/server/commands/m-dns.ts

@@ -3,7 +3,7 @@
 import type { AdbServerClient } from "../client.js";
 
 export class MDnsCommands {
-    #client: AdbServerClient;
+    readonly #client: AdbServerClient;
 
     constructor(client: AdbServerClient) {
         this.#client = client;

libraries/adb/src/server/commands/wireless.ts

@@ -26,7 +26,7 @@ export class AlreadyConnectedError extends Error {
 }
 
 export class WirelessCommands {
-    #client: AdbServerClient;
+    readonly #client: AdbServerClient;
 
     constructor(client: AdbServerClient) {
         this.#client = client;

libraries/struct/src/field/factory.ts

@@ -9,7 +9,7 @@ import type {
 import { byobFieldSerializer, defaultFieldSerializer } from "./serialize.js";
 import type { Field, FieldDeserializeContext, FieldOptions } from "./types.js";
 
-export type MaybeBipedalFieldDeserializer<T, D> = BipedalGenerator<
+export type BipedalFieldDeserializer<T, D> = BipedalGenerator<
     undefined,
     T,
     [reader: AsyncExactReadable, context: FieldDeserializeContext<D>]
@@ -20,7 +20,7 @@ function _field<T, OmitInit extends string, D, Raw = T>(
     size: number,
     type: "default",
     serialize: DefaultFieldSerializer<Raw>,
-    deserialize: MaybeBipedalFieldDeserializer<T, D>,
+    deserialize: BipedalFieldDeserializer<T, D>,
     options?: FieldOptions<T, OmitInit, D, Raw>,
 ): Field<T, OmitInit, D, Raw>;
 // eslint-disable-next-line @typescript-eslint/max-params
@@ -28,7 +28,7 @@ function _field<T, OmitInit extends string, D, Raw = T>(
     size: number,
     type: "byob",
     serialize: ByobFieldSerializer<Raw>,
-    deserialize: MaybeBipedalFieldDeserializer<T, D>,
+    deserialize: BipedalFieldDeserializer<T, D>,
     options?: FieldOptions<T, OmitInit, D, Raw>,
 ): Field<T, OmitInit, D, Raw>;
 /* #__NO_SIDE_EFFECTS__ */
@@ -37,7 +37,7 @@ function _field<T, OmitInit extends string, D, Raw = T>(
     size: number,
     type: "default" | "byob",
     serialize: DefaultFieldSerializer<Raw> | ByobFieldSerializer<Raw>,
-    deserialize: MaybeBipedalFieldDeserializer<T, D>,
+    deserialize: BipedalFieldDeserializer<T, D>,
     options?: FieldOptions<T, OmitInit, D, Raw>,
 ): Field<T, OmitInit, D, Raw> {
     const field: Field<T, OmitInit, D, Raw> = {

toolchain/eslint-config/eslint.config.js

@@ -25,6 +25,7 @@ export default tslint.config(
                     maxBOF: 0,
                 },
             ],
+            "no-fallthrough": "off",
         },
     },
     ...tslint.configs.recommendedTypeChecked,