yetangitu/ya-webadb
1
0
Fork 0
mirror of https://github.com/yume-chan/ya-webadb.git synced 2025-10-04 10:19:17 +02:00
Code Issues Projects Releases Packages Wiki Activity

refactor(adb): pre-encode packet ID as number in sync command

Browse source
This commit is contained in:
Simon Chan 2024-05-24 16:55:26 +08:00
parent 25efbe6402
commit 2db3e8f8b9
No known key found for this signature in database
GPG key ID: A8B69F750B9BCEDD
8 changed files with 90 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

15
libraries/android-bin/src/pm.ts
View file

@ -273,10 +273,17 @@ export class PackageManager extends AdbCommandBase {
PACKAGE_MANAGER_INSTALL_OPTIONS_MAP,
);
if (!options?.skipExisting) {
// Today `pm` defaults to replace existing application (`-r` will be ignored),
// but old versions defaults to skip existing application (like `-R`, but obviously
// they didn't have this switch and ignores it if present).
// If `skipExisting` is not set, add `-r` to ensure compatibility with old versions.
/*
* | behavior | previous version | modern version |
* | -------------------- | -------------------- | -------------------- |
* | replace existing app | requires `-r` | default behavior [1] |
* | skip existing app | default behavior [2] | requires `-R` |
*
* [1]: `-r` recognized but ignored)
* [2]: `-R` not recognized but ignored
*
* So add `-r` when `skipExisting` is `false` for compatibility.
*/
args.push("-r");
}
return args;