From cf276c5b9cd13d916c12bbcf70b43065a63e9b2c Mon Sep 17 00:00:00 2001
From: Simon Chan <1330321+yume-chan@users.noreply.github.com>
Date: Tue, 9 Sep 2025 23:37:06 +0800
Subject: [PATCH] chore: fix review comments

---
 libraries/adb-daemon-webusb/src/device.ts         | 10 ----------
 libraries/adb-scrcpy/src/3_3_2.ts                 |  2 +-
 libraries/adb/src/utils/array-buffer.ts           |  4 +---
 libraries/scrcpy/src/base/control-message-type.ts |  2 +-
 4 files changed, 3 insertions(+), 15 deletions(-)

diff --git a/libraries/adb-daemon-webusb/src/device.ts b/libraries/adb-daemon-webusb/src/device.ts
index 31cab37c..51e107f7 100644
--- a/libraries/adb-daemon-webusb/src/device.ts
+++ b/libraries/adb-daemon-webusb/src/device.ts
@@ -143,16 +143,6 @@ export class AdbDaemonWebUsbConnection
                 new MaybeConsumable.WritableStream({
                     write: async (chunk) => {
                         try {
-                            if (
-                                typeof SharedArrayBuffer !== "undefined" &&
-                                chunk.buffer instanceof SharedArrayBuffer
-                            ) {
-                                // Copy data to a non-shared ArrayBuffer
-                                const copy = new Uint8Array(chunk.byteLength);
-                                copy.set(chunk);
-                                chunk = copy;
-                            }
-
                             await device.raw.transferOut(
                                 outEndpoint.endpointNumber,
                                 // WebUSB doesn't support SharedArrayBuffer
diff --git a/libraries/adb-scrcpy/src/3_3_2.ts b/libraries/adb-scrcpy/src/3_3_2.ts
index 559d04c0..a926d6aa 100644
--- a/libraries/adb-scrcpy/src/3_3_2.ts
+++ b/libraries/adb-scrcpy/src/3_3_2.ts
@@ -27,7 +27,7 @@ export class AdbScrcpyOptions3_3_2<TVideo extends boolean>
     ) {
         super(init);
 
-        this.version = clientOptions?.version ?? "3.3.1";
+        this.version = clientOptions?.version ?? "3.3.2";
         this.spawner = clientOptions?.spawner;
     }
 
diff --git a/libraries/adb/src/utils/array-buffer.ts b/libraries/adb/src/utils/array-buffer.ts
index 7d6cc98f..981f696b 100644
--- a/libraries/adb/src/utils/array-buffer.ts
+++ b/libraries/adb/src/utils/array-buffer.ts
@@ -3,7 +3,5 @@ export function toLocalUint8Array(value: Uint8Array): Uint8Array<ArrayBuffer> {
         return value as Uint8Array<ArrayBuffer>;
     }
 
-    const copy = new Uint8Array(value.length);
-    copy.set(value);
-    return copy;
+    return new Uint8Array(value);
 }
diff --git a/libraries/scrcpy/src/base/control-message-type.ts b/libraries/scrcpy/src/base/control-message-type.ts
index 3ef20da1..d38b2bb1 100644
--- a/libraries/scrcpy/src/base/control-message-type.ts
+++ b/libraries/scrcpy/src/base/control-message-type.ts
@@ -1,6 +1,6 @@
 import * as ScrcpyControlMessageType from "./control-message-type-value.js";
 
-// These IDs change between versions, so always use `options.getControlMessageTypes()`
+// These IDs change between versions, so always use `options.controlMessageTypes`
 // biome-ignore lint/suspicious/noRedeclare: TypeScript declaration merging for enum-like object
 type ScrcpyControlMessageType =
     (typeof ScrcpyControlMessageType)[keyof typeof ScrcpyControlMessageType];