yetangitu/Battery-Emulator
1
0
Fork 0
mirror of https://github.com/dalathegreat/Battery-Emulator.git synced 2025-10-03 09:49:32 +02:00
Code Issues Projects Releases Packages Wiki Activity

Update TODO comments

Browse source
This commit is contained in:
Daniel Öster 2025-03-30 22:25:34 +03:00
parent be7a79686a
commit 9b77b135b6
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Software/src/battery/CMFA-EV-BATTERY.cpp
View file

@ -5,15 +5,11 @@
#include "CMFA-EV-BATTERY.h" #include "CMFA-EV-BATTERY.h"
/* TODO: /* TODO:
Before this integration can be considered stable, we need to: Integration considered stable! Following points can still be improved:
- Find the following data points in the transmitted CAN data: - Cellvoltage Min missing. Value now mapped to same as Cellvoltage Max
- Pack voltage (Current implementation might be wrong) - All individual cellvoltages can not yet be viewed in the cellmonitor
- Cellvoltage min
- Cellvoltage max
- Alternatively all these values can be taken from OBD2 PID polling
/* /*
/* Do not change code below unless you are sure what you are doing */ /* Do not change code below unless you are sure what you are doing */
CAN_frame CMFA_1EA = {.FD = false, .ext_ID = false, .DLC = 1, .ID = 0x1EA, .data = {0x00}}; CAN_frame CMFA_1EA = {.FD = false, .ext_ID = false, .DLC = 1, .ID = 0x1EA, .data = {0x00}};
CAN_frame CMFA_125 = {.FD = false, CAN_frame CMFA_125 = {.FD = false,
@ -33,7 +29,6 @@ CAN_frame CMFA_3D3 = {.FD = false,
.ID = 0x3D3, .ID = 0x3D3,
.data = {0x47, 0x30, 0x00, 0x02, 0x5D, 0x80, 0x5D, 0xE7}}; .data = {0x47, 0x30, 0x00, 0x02, 0x5D, 0x80, 0x5D, 0xE7}};
CAN_frame CMFA_59B = {.FD = false, .ext_ID = false, .DLC = 3, .ID = 0x59B, .data = {0x00, 0x02, 0x00}}; CAN_frame CMFA_59B = {.FD = false, .ext_ID = false, .DLC = 3, .ID = 0x59B, .data = {0x00, 0x02, 0x00}};
CAN_frame CMFA_ACK = {.FD = false, CAN_frame CMFA_ACK = {.FD = false,
.ext_ID = false, .ext_ID = false,
.DLC = 8, .DLC = 8,