Merge pull request #505 from amarofarinha/main

Improve OTA Update by Removing Delay and Immediate CAN Control
This commit is contained in:
amarofarinha 2024-09-29 18:14:15 +01:00 committed by GitHub
commit c2433bd81b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 6 deletions

View file

@ -220,6 +220,9 @@ void setBatteryPause(bool pause_battery, bool pause_CAN) {
emulator_pause_status = RESUMING; emulator_pause_status = RESUMING;
clear_event(EVENT_PAUSE_END); clear_event(EVENT_PAUSE_END);
} }
//immediate check if we can send CAN messages
emulator_pause_state_send_CAN_battery();
} }
/// @brief handle emulator pause status /// @brief handle emulator pause status

View file

@ -46,12 +46,6 @@ void ElegantOTAClass::begin(ELEGANTOTA_WEBSERVER *server, const char * username,
// Pre-OTA update callback // Pre-OTA update callback
if (preUpdateCallback != NULL) preUpdateCallback(); if (preUpdateCallback != NULL) preUpdateCallback();
// Sleep for 3 seconds to allow asynchronous preUpdateCallback tasks to complete
unsigned long sleepStart = millis();
while (millis() - sleepStart < 3000) { // Sleep for 3 second
delay(1); // Yield to other tasks
}
// Get header x-ota-mode value, if present // Get header x-ota-mode value, if present
OTA_Mode mode = OTA_MODE_FIRMWARE; OTA_Mode mode = OTA_MODE_FIRMWARE;
// Get mode from arg // Get mode from arg