Paul Arthur
b51b45952e
Some cleanup of the switch in stream.php
...
Add correct array indices to hand-crafted arrays in single_song and
download cases. Yank unimplemented popular stuff.
2013-01-15 01:26:37 -05:00
Paul Arthur
4afe4b507b
Cosmetics: correct outdated tmpPlaylist comment
2013-01-15 01:26:37 -05:00
Paul Arthur
663798897f
Cosmetics: remove unused variables in Stream
2013-01-14 13:57:20 -05:00
Paul Arthur
e7768b1634
Drop unused static rating, whatever that was
2012-12-19 13:09:12 -05:00
Paul Arthur
099a391d41
Use Ajax::url in the browse filters
2012-12-19 13:09:12 -05:00
Paul Arthur
b423def173
Add a convenience function to generate an AJAX url
2012-12-19 12:54:58 -05:00
Paul Arthur
d30249d66f
Drop unused ajax_url variables
2012-12-19 12:48:48 -05:00
Paul Arthur
0982bc392e
Use Ajax::action to generate the browse AJAX.
2012-12-19 12:44:20 -05:00
Paul Arthur
30ff5b0048
Use Ajax::action to generate the refresh URL
...
Handcrafting it is unnecessary.
2012-12-19 12:41:49 -05:00
Paul Arthur
8444fd6b1e
Finalise 3.6-alpha4
2012-11-27 14:47:46 -05:00
Paul Arthur
4e247196ff
Rip out ugly lyrics code
2012-11-13 18:51:11 -05:00
Paul Arthur
75b6969ae1
Cosmetics: fix typo
2012-11-13 18:44:46 -05:00
Paul Arthur
04d5d6192c
Drop undocumented mail option for bin/print_tags
2012-11-13 18:42:57 -05:00
Paul Arthur
2a93f0b9c1
MPD: Drop outdated README, use json_encode
2012-11-13 18:36:58 -05:00
Paul Arthur
d772b031a9
Switch from print_r to json_encode in debug output
2012-11-13 18:31:33 -05:00
Paul Arthur
915b29c985
check_database() -> Dba::check_database()
2012-11-08 14:42:48 -05:00
Paul Arthur
649298b241
Clean up remaining direct calls to mysql functions
...
This makes it theoretically possible to replace Dba with a different
implementation somewhat painlessly.
2012-11-08 14:31:53 -05:00
Paul Arthur
c51ddbd3d6
Clean up check_database, more direct mysql calls
2012-11-08 14:02:28 -05:00
Paul Arthur
70b37ad472
Clean up direct callers of mysql_error()
2012-11-08 13:34:58 -05:00
Paul Arthur
54f9633498
Cosmetics: clean up spaces
2012-11-08 13:23:27 -05:00
Paul Arthur
93251b3c8d
Move check_database_inserted into the Dba class
2012-11-08 13:22:56 -05:00
Paul Arthur
d2eaf10b07
Move check_database into the Dba class
2012-11-08 13:15:19 -05:00
Paul Arthur
0d78b77443
Cosmetics: Fix capitalisation
2012-10-18 18:17:50 -04:00
Paul Arthur
bea34c4261
Fix spurious errors from Catalog::create()
...
is_readable is flaky under Windows, opendir should be more accurate.
2012-10-18 18:16:30 -04:00
Paul Arthur
8821554dda
Mainly cosmetic cleanup of the catalog update complete message
2012-10-16 20:35:40 -04:00
Paul Arthur
bc90c0128c
Start cleaning up the democratic thing.
...
Whoever wrote the old implementation of get_items suffered from intense fear
and hatred of SQL.
2012-10-15 13:20:28 -04:00
Paul Arthur
8c4921f5f3
Consistently use 'object_type' in playlist returns
2012-10-15 13:20:27 -04:00
Paul Arthur
d7c0531871
Finalise 3.6-alpha3
2012-10-15 13:20:27 -04:00
Paul Arthur
10b2d039d4
Update getID3 to 1.9.4b1
...
Notably: "PHP5 standards improvements". Maybe it will throw less
PHP warnings now.
2012-10-11 14:59:57 -04:00
Paul Arthur
866e7f4a1c
Add Search->get_random_items
2012-10-01 12:44:36 -04:00
Paul Arthur
cd98c2ed6d
Fix inaccurate comment.
2012-10-01 12:21:09 -04:00
Paul Arthur
92e29041a4
Drop support for old passwords
2012-09-21 14:28:53 -04:00
Paul Arthur
a24b711143
Some cleanup of the playlist import code
...
Global variables are ugly and unnecessary.
2012-09-21 10:52:47 -04:00
Florent Fourcot
c9dab7bf4e
FS#262 - M3U import should be ordered
2012-09-21 10:11:23 -04:00
Paul Arthur
af4a77d145
image.php: Unify code paths, use Horde_Browser
...
We had two code paths that did basically identical things, and a bug
was fixed in one but not the other because that's what happens.
Using Horde_Browser instead of hand-crafting headers would have
avoided the bug in the first place, so do that as well.
2012-09-20 14:08:01 -04:00
Paul Arthur
9c09b33e95
FS#248 - Sending Mail with quotes
...
Don't run scrub_in on the subject and body; it's not touching the
database or being output back to the browser, and we send plain text
email. Anything malicious that can be done is a phpmailer bug.
2012-09-20 12:50:54 -04:00
Paul Arthur
2f8656a20c
FS#202 - Stats not registered on some songs
...
Removed check from User->update_stats. It looks iffy, is reported to be
broken, and everything that calls it has an independent check.
2012-09-20 12:13:51 -04:00
Paul Arthur
8a06c9a80c
Clean up template show_now_playing_row
...
Song title was linked to yet another inconsistent action and links were
being built from scratch instead of using the perfectly good
preformatted ones.
2012-09-20 11:59:55 -04:00
Paul Arthur
7ff92215de
FS#142 - Clicking on song results in downloading
...
Change the title link in a song row so it links to the song details.
While there's no real value in obfuscating the fact that a stream
can be downloaded, there is value in a consistent interface. The
song title being a stream link is inconsistent with other parts of
the row (such as album and artist), inconsistent with other times we
display songs (such as Recently Played), and doesn't consistently match
the currently selected playback method.
2012-09-20 11:44:42 -04:00
Paul Arthur
bd7bf80aae
FS#249 - SQL error for iAmpache client
...
Add a sanity check before we attempt to execute the SQL statement
2012-09-20 11:22:48 -04:00
Paul Arthur
afd69ce334
Cosmetics: api::url_to_song
2012-09-20 11:22:48 -04:00
Paul Arthur
bba378c39b
Cosmetics: xmlData::songs
2012-09-20 11:22:48 -04:00
Paul Arthur
de300b2c16
Cosmetics: Song::build_cache
2012-09-20 11:22:42 -04:00
Paul Arthur
0086e772db
FS#260 - Multiple rules result in "Not Enough Data"
...
This should be a more complete fix, and possibly a somewhat more
efficient approach.
2012-09-19 17:05:07 -04:00
Paul Arthur
256a312af3
FS#260 - Multiple rules result in "Not Enough Data"
...
This quick fix probably won't interact properly with smart playlists,
and it doesn't seem like a very efficient approach. But it's less
broken.
2012-09-17 10:43:39 -04:00
Paul Arthur
e9d8c44f64
FS#257 - Social comments function not working.
...
make_bool is definitely the wrong way to handle the parameter. This
(untested) change might fix the bug.
2012-09-17 10:41:13 -04:00
Paul Arthur
25b77a6c75
Partial fix for ASF tags
...
Actually transfer all ASF tags into the asf tag array. I suspect that
some things like 'genre' may actually be multivalued, but I don't have
any samples to back that up.
2012-09-06 12:56:20 -04:00
momo-i
dabbea660f
update languages
2012-08-17 16:44:09 +09:00
Paul Arthur
b4b6c7a47e
Finalise alpha2
...
I'm tired of seeing alpha1.
2012-08-15 11:55:07 -04:00
Paul Arthur
e8f5f470da
Update prototype to git HEAD (ecacc0246f)
...
git://github.com/sstephenson/prototype.git
2012-08-11 14:14:30 -04:00
