Paul Arthur
4afe4b507b
Cosmetics: correct outdated tmpPlaylist comment
2013-01-15 01:26:37 -05:00
Paul Arthur
663798897f
Cosmetics: remove unused variables in Stream
2013-01-14 13:57:20 -05:00
Paul Arthur
e7768b1634
Drop unused static rating, whatever that was
2012-12-19 13:09:12 -05:00
Paul Arthur
b423def173
Add a convenience function to generate an AJAX url
2012-12-19 12:54:58 -05:00
Paul Arthur
0982bc392e
Use Ajax::action to generate the browse AJAX.
2012-12-19 12:44:20 -05:00
Paul Arthur
8444fd6b1e
Finalise 3.6-alpha4
2012-11-27 14:47:46 -05:00
Paul Arthur
4e247196ff
Rip out ugly lyrics code
2012-11-13 18:51:11 -05:00
Paul Arthur
75b6969ae1
Cosmetics: fix typo
2012-11-13 18:44:46 -05:00
Paul Arthur
d772b031a9
Switch from print_r to json_encode in debug output
2012-11-13 18:31:33 -05:00
Paul Arthur
649298b241
Clean up remaining direct calls to mysql functions
...
This makes it theoretically possible to replace Dba with a different
implementation somewhat painlessly.
2012-11-08 14:31:53 -05:00
Paul Arthur
c51ddbd3d6
Clean up check_database, more direct mysql calls
2012-11-08 14:02:28 -05:00
Paul Arthur
70b37ad472
Clean up direct callers of mysql_error()
2012-11-08 13:34:58 -05:00
Paul Arthur
54f9633498
Cosmetics: clean up spaces
2012-11-08 13:23:27 -05:00
Paul Arthur
93251b3c8d
Move check_database_inserted into the Dba class
2012-11-08 13:22:56 -05:00
Paul Arthur
d2eaf10b07
Move check_database into the Dba class
2012-11-08 13:15:19 -05:00
Paul Arthur
bea34c4261
Fix spurious errors from Catalog::create()
...
is_readable is flaky under Windows, opendir should be more accurate.
2012-10-18 18:16:30 -04:00
Paul Arthur
8821554dda
Mainly cosmetic cleanup of the catalog update complete message
2012-10-16 20:35:40 -04:00
Paul Arthur
bc90c0128c
Start cleaning up the democratic thing.
...
Whoever wrote the old implementation of get_items suffered from intense fear
and hatred of SQL.
2012-10-15 13:20:28 -04:00
Paul Arthur
8c4921f5f3
Consistently use 'object_type' in playlist returns
2012-10-15 13:20:27 -04:00
Paul Arthur
d7c0531871
Finalise 3.6-alpha3
2012-10-15 13:20:27 -04:00
Paul Arthur
866e7f4a1c
Add Search->get_random_items
2012-10-01 12:44:36 -04:00
Paul Arthur
cd98c2ed6d
Fix inaccurate comment.
2012-10-01 12:21:09 -04:00
Paul Arthur
92e29041a4
Drop support for old passwords
2012-09-21 14:28:53 -04:00
Paul Arthur
a24b711143
Some cleanup of the playlist import code
...
Global variables are ugly and unnecessary.
2012-09-21 10:52:47 -04:00
Florent Fourcot
c9dab7bf4e
FS#262 - M3U import should be ordered
2012-09-21 10:11:23 -04:00
Paul Arthur
2f8656a20c
FS#202 - Stats not registered on some songs
...
Removed check from User->update_stats. It looks iffy, is reported to be
broken, and everything that calls it has an independent check.
2012-09-20 12:13:51 -04:00
Paul Arthur
bd7bf80aae
FS#249 - SQL error for iAmpache client
...
Add a sanity check before we attempt to execute the SQL statement
2012-09-20 11:22:48 -04:00
Paul Arthur
afd69ce334
Cosmetics: api::url_to_song
2012-09-20 11:22:48 -04:00
Paul Arthur
bba378c39b
Cosmetics: xmlData::songs
2012-09-20 11:22:48 -04:00
Paul Arthur
de300b2c16
Cosmetics: Song::build_cache
2012-09-20 11:22:42 -04:00
Paul Arthur
0086e772db
FS#260 - Multiple rules result in "Not Enough Data"
...
This should be a more complete fix, and possibly a somewhat more
efficient approach.
2012-09-19 17:05:07 -04:00
Paul Arthur
256a312af3
FS#260 - Multiple rules result in "Not Enough Data"
...
This quick fix probably won't interact properly with smart playlists,
and it doesn't seem like a very efficient approach. But it's less
broken.
2012-09-17 10:43:39 -04:00
Paul Arthur
e9d8c44f64
FS#257 - Social comments function not working.
...
make_bool is definitely the wrong way to handle the parameter. This
(untested) change might fix the bug.
2012-09-17 10:41:13 -04:00
Paul Arthur
25b77a6c75
Partial fix for ASF tags
...
Actually transfer all ASF tags into the asf tag array. I suspect that
some things like 'genre' may actually be multivalued, but I don't have
any samples to back that up.
2012-09-06 12:56:20 -04:00
Paul Arthur
b4b6c7a47e
Finalise alpha2
...
I'm tired of seeing alpha1.
2012-08-15 11:55:07 -04:00
Paul Arthur
33d07e8910
Make a debug message less alarming
...
It's expected that reading from sessions will fail after expiry or
before login. Remove the word 'error' from the logged message and bump
it down a few levels.
2012-07-24 16:46:21 -04:00
Paul Arthur
cad8d6ac86
web_path cleanup
...
force_ssl was broken, should be fixed now.
2012-07-11 14:37:11 -04:00
Paul Arthur
4ea8af4968
Remove more code that only ran on PHP <5.3
2012-07-01 22:30:32 -04:00
Paul Arthur
567b27954b
Clean up set_memory_limit
...
ini_set should be passed an integer byte value; shorthand byte values
should only be used in php.ini. It's bad to assume that values are
always in megabytes; we could enforce it in our config file if we
cared, but not in PHP's.
2012-07-01 17:09:36 -04:00
Paul Arthur
408e71344a
escapeshellarg's behaviour is locale-dependent
...
Reimplement it locally so it isn't. Might fix FS#252.
2012-05-25 16:52:57 -04:00
Paul Arthur
09949bb20b
Fix typo
2012-05-09 12:16:33 -04:00
Paul Arthur
5f2f81fa8f
Use spl_autoload_register instead of __autoload
...
Might be useful in the future, __autoload is discouraged according to
the PHP documentation.
2012-04-18 00:54:54 -04:00
Paul Arthur
37fc03bb48
Make the CLI database installation tool more robust
...
Using a relative path required it to be run from the top-level
directory; we already do voodoo to figure out the correct prefix, so we
should use that.
2012-04-17 17:53:52 -04:00
Paul Arthur
e1c3a21b37
Drop old code related to mysql < 5.0
2012-04-17 14:29:50 -04:00
Paul Arthur
8a93c849e2
FS#226 - does not catch MySQL errors before passing to num_rows()
...
Clean up Dba::num_rows (based on a patch by Natureshadow)
We could check before every call instead, but screw that.
2012-04-15 23:32:03 -04:00
Dominik George
b64649e720
FS#225 - xml_from_array() produces runtime error
...
Newer versions of the PCRE library changed behaviour so we can't
replace invalid characters by listing them, since it now requires
that the characters in a pattern are valid Unicode characters. Use an
inverted character class instead.
Might work.
2012-04-15 23:31:17 -04:00
Paul Arthur
4aa37feccc
Fix disk number parsing for ID3v2
...
According to the changelog, getID3 1.7.9 standardised on part_of_a_set
as the key for this info (pulled from TPOS or TPA, depending on the
minor version of ID3v2); we were looking for 'pos', which is wrong.
2012-04-15 03:02:29 -04:00
Paul Arthur
512f77a70c
Support setting a custom format for the rss feed
2012-04-13 17:59:16 -04:00
Paul Arthur
8af2544b27
Refactor getting MBIDs from ID3 tags
...
Just grab the info from the TXXX bit, instead of relying on a
correlation between the raw tags and the cooked ones.
2012-04-12 21:56:27 -04:00
Paul Arthur
ecdb8bc02d
Add support for pulling ratings from id3 tags
...
Not used by anything yet, but it might work.
2012-04-12 21:42:44 -04:00
