yetangitu/ghidra
1
0
Fork 0
mirror of https://github.com/NationalSecurityAgency/ghidra.git synced 2025-10-03 01:39:21 +02:00
Code Issues Releases Wiki Activity

Fix idaxml set_member_cmt func call

Browse source 
The script originally was incorrectly calling `idc.set_member_cmt` which
takes different arguments to calculate the member struct and offset. And
then it passes the results into the `ida_struct` version. However, this is
already done, so we can just go straight to the `ida_struct` version.
This commit is contained in:
Paul Sorensen 2021-03-30 13:39:59 -04:00 • committed by GitHub
parent 90f3a48362
commit b7e048df77
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
GhidraBuild/IDAPro/Python/7xx/python/idaxml.py
View file

@ -3111,11 +3111,11 @@ class XmlImporter(IdaXml):
""" """
regcmt = member.find(REGULAR_CMT) regcmt = member.find(REGULAR_CMT)
if regcmt != None: if regcmt != None:
idc.set_member_cmt(mbr, regcmt.text, False) ida_struct.set_member_cmt(mbr, regcmt.text, False)
self.update_counter(MEMBER + ':' + REGULAR_CMT) self.update_counter(MEMBER + ':' + REGULAR_CMT)
rptcmt = member.find(REPEATABLE_CMT) rptcmt = member.find(REPEATABLE_CMT)
if rptcmt != None: if rptcmt != None:
idc.set_member_cmt(mbr, rptcmt.text, True) ida_struct.set_member_cmt(mbr, rptcmt.text, True)
self.update_counter(MEMBER + ':' + REPEATABLE_CMT) self.update_counter(MEMBER + ':' + REPEATABLE_CMT)